Clean up remaining getattr connection DbApiHook #40665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n get_conn_id method from DbApiHook
…s using the new get_conn_id method of the DbApiHook
…on conn_name_attr
boring-cyborg
bot
added
area:providers
provider:apache-druid
provider:apache-drill
provider:apache-pinot
provider:apache-impala
provider:elasticsearch
provider:exasol
provider:jdbc
provider:microsoft-mssql
provider:mysql
provider:odbc
provider:postgres
provider:snowflake
|
The pre-commit needs to be run as suggested in the error message :) |
…ate of minimal apache-airflow-providers-common-sql version
dabla
changed the title
|
I get follow error stating that I need to regenerate the provider constraints, but when I run the follow command in breeze nothing is changed: breeze static-checks --type update-providers-dependencies --all-files Also my branch is up-to-date with gitbuh. |
|
Can you rebase it please @dabla ? I believe a conflicting change was merged soon after you pushed the PR and that's the root cause (currentlly you cannot even rebase it with the UI as it have conflicting changes (on dependencies update). |
|
|
potiuk
approved these changes
Jul 16, 2024
2 tasks
potiuk
approved these changes
Jul 19, 2024
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
--------- Co-authored-by: David Blain <david.blain@infrabel.be> Co-authored-by: David Blain <david.blain@b-holding.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request also applies the cleanup done in the DbApiHook throughout all depending hooks regarding the duplicated calls using the getattr on the conn_name_attr. This was already done within the DbApiHook itself in the fix for PR 40615. The only drawback of this change is that all providers then need to update the min required version of the common.sql provider to be at the latest version.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.