-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fernet-key-rotation-optimisation #40786
Fernet-key-rotation-optimisation #40786
Conversation
Tests that are failing don't seem even remotely related to introduced change.
|
Yes. They are flaky tests that are failing in main too and need to be fixed there- previous attempt was not successful #40766 |
Should be fixed by - #40813 - it was a really weird timing issue - when test was parsed before hour and executed after hour. |
Thanks! I will observe this PR and re-run the tests once merged. |
…l()` method on the processed tables leading to loading all rows to memory. It's been observed that some users store additional data in `variable` table which is leading to memory issues during the operation. This change introduces batch processing of fernet key rotation to avoid it. To be consistent across the tables (`variable`, `connection`, `trigger`) the batching operation was added for all of them.
364bad7
to
136cfea
Compare
Merged (and I rebased your PR as well) |
It looks like more flaky tests failing. |
Yeah. Looks, like recent open-lineage change cc: @mobuchowski @kacpermuda - any hint? |
Just for reference, OL test was fixed in #40826. |
* Current implementation of Fernet key rotation implicitly executes `all()` method on the processed tables leading to loading all rows to memory. It's been observed that some users store additional data in `variable` table which is leading to memory issues during the operation. This change introduces batch processing of fernet key rotation to avoid it. To be consistent across the tables (`variable`, `connection`, `trigger`) the batching operation was added for all of them. --------- Co-authored-by: bjankiewicz <bjankiewicz@google.com>
Cherry-pick apache/airflow#40786 Change-Id: I932ddd7325184286d75ff5cedde9fe17ee4c4e37 GitOrigin-RevId: c5f130be5627227b8816e8a510c89aa320529ccf
Cherry-pick apache/airflow#40786 Change-Id: I7779acc5fa4bf0bdb2486cb5a00edcedf0d0c885 GitOrigin-RevId: 4aeaac5deaba80b7769bbd78d87e504100e065b3
This is a follow up to reverted #40758
Current implementation of Fernet key rotation implicitly executes
all()
method on the processed tables leading to loading all rows to memory.It's been observed that some users store additional data in
variable
table which is leading to memory issues during the operation.This change introduces batch processing of fernet key rotation to avoid it. To be consistent across the tables (
variable
,connection
,trigger
) the batching operation was added for all of them.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.