Simplify _auth_manager_is_authorized_map function #40803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a lot of boilerplate. I extract the duplicate logic for the two main cases out into helper functions. Helps make clearer what's going on.
dstandish
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
vincbeck
approved these changes
Jul 16, 2024
ephraimbuddy
added
the
type:misc/internal
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
There's a lot of boilerplate. I extract the duplicate logic for the two main cases out into helper functions. Hopefully makes it a little clearer what's going on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at this cus I needed to add permissions for a new model, and felt like it was a lot of boilerplate. I extract the duplicate logic for the two main cases out into helper functions. Helps make clearer what's going on.