Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only orphan non-orphaned Datasets #40806

Merged

Conversation

stijndehaes
Copy link
Contributor

This change makes sure only non-orphaned Datasets are checked if they need to be orphaned.
In a quite big Airflow installation we saw a spam of logs that the same Datasets where being Orphaned but they were already Orphaned resulting in a lot of unnecessary work and logs.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:Scheduler including HA (high availability) scheduler label Jul 16, 2024
@stijndehaes stijndehaes force-pushed the feature/only-orphan-unorphaned-datsets branch 2 times, most recently from b285142 to 377df5f Compare July 18, 2024 14:17
@shahar1
Copy link
Contributor

shahar1 commented Jul 19, 2024

@kaxil @ashb I'd be happy if either of you could take a look before merging :)

@stijndehaes
Copy link
Contributor Author

@kaxil @ashb a friendly reminder to have a look at this PR?

@shahar1
Copy link
Contributor

shahar1 commented Aug 2, 2024

Rebasing to main before merging

@shahar1 shahar1 force-pushed the feature/only-orphan-unorphaned-datsets branch from 377df5f to 82832e4 Compare August 2, 2024 20:25
@shahar1 shahar1 merged commit c31069d into apache:main Aug 2, 2024
48 checks passed
@utkarsharma2 utkarsharma2 added the type:improvement Changelog: Improvements label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Scheduler including HA (high availability) scheduler type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants