Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-62: add method to common.compat to not force hooks to try/except every time #40812

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

mobuchowski
Copy link
Contributor

We introduce airflow.lineage.hook in 2.10. Every time, providers would need to try/except import from it, because they need to be compatible with lower version of Airflow.

However, depending on newest common.compat provider gives us ability to centralize that logic and make providers simpler.

@mobuchowski mobuchowski added the AIP-62 Tasks tracking implementation of AIP-62 Getting Lineage from Hook Instrumentation label Jul 16, 2024
@mobuchowski mobuchowski force-pushed the aip-62/common-compat branch 3 times, most recently from b4d1e7e to 359b73c Compare July 16, 2024 12:51
@mobuchowski mobuchowski changed the title openlineage: add method to common.compat to not force hooks to try/except every time AIP-62: add method to common.compat to not force hooks to try/except every time Jul 16, 2024
@mobuchowski mobuchowski force-pushed the aip-62/common-compat branch 2 times, most recently from 7536900 to 418aa31 Compare July 16, 2024 16:13
…cept every 2.10 hook lineage call

Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
@mobuchowski mobuchowski merged commit 6366204 into main Jul 16, 2024
79 checks passed
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jul 22, 2024
@ephraimbuddy ephraimbuddy added this to the Airflow 2.10.0 milestone Jul 23, 2024
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
…cept every 2.10 hook lineage call (apache#40812)

Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
@mobuchowski mobuchowski deleted the aip-62/common-compat branch August 2, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AIP-62 Tasks tracking implementation of AIP-62 Getting Lineage from Hook Instrumentation area:dev-tools area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants