-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: never_fail in sensor #40915
fix: never_fail in sensor #40915
Conversation
I feel I'm still not sure what the main difference is between |
I agree
I agree. This is very confusing. |
To my understanding |
yes but this will need all providers to required airflow 2.10.0 since it would be a big breaking change, that's why I wrote |
I thought about it when reviewing it, but I came to the same conclusion as Raphael regarding being a breaking change. |
yes what about |
I don't follow why? We can have backward compatiblity for the current functionality and place the new functionality under version flag. |
Sorry, I guess it was me that did not express myself well enough here. What I meant is introducing a new parameter for specific sensor instead of adding it to |
yes I can introduce a what about
? |
Yes I updated the doc in the second PR #40923 |
Yes, this is something we could discuss whether we want to make it a new feature and I'm ok with it.
It looks like a breaking change to me and not something we can fix just by updating the description. It's possible that @shahar1 's suggestion on changing it to |
before 2.7.1 soft_fail was not related to every exception. So it's a quit recent and breaking change that my PR isolated in |
The reason why we made those changes was that the sensor did not do |
* fix: never_fail in sensor * fix: tests * fix: tests 2 * review 1 - doc --------- Co-authored-by: raphaelauv <raphaelauv@users.noreply.github.com>
Coming in a bit late, but I took it the same way and have the same concern as @Lee-W. |
to ignore other errors there is the So |
Hi, just to put my 2 cents - I was just reading the docs for both modes:
and tbh - I still understand nothing. It seems like Astro docs make it even more confusing as they refer to
|
@raphaelauv what you mean is:
Is that correct? But I still don't get it why |
fix: #40787
introduce the settings
never_fail
sosoft_fail
no more ignore technical errorsbefore a probably full refacto of how sensors skip themself