Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update styles for renderedjson component #40964

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

bbovenzi
Copy link
Contributor

Make sure the RenderedJson component matches the font and font size of the rest of the UI. And allow it to accept custom styling of its wrapper component

Before:
Screenshot 2024-07-23 at 11 52 11 AM

After:
Screenshot 2024-07-23 at 11 51 40 AM


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@bbovenzi bbovenzi added this to the Airflow 2.10.0 milestone Jul 23, 2024
@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Jul 23, 2024
Copy link
Contributor

@ryanahamilton ryanahamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bbovenzi bbovenzi merged commit b713b30 into apache:main Jul 23, 2024
48 checks passed
@bbovenzi bbovenzi deleted the rendered-json-styling branch July 23, 2024 16:23
@ephraimbuddy ephraimbuddy added the type:improvement Changelog: Improvements label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants