Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openlineage: make value of slots in attrs.define consistent #40992

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

kacpermuda
Copy link
Contributor

Followup to #40972. Across the whole codebase, we are using attrs.define sometimes with default value of slots=True, sometimes with explicit set to False. This PR makes sure it's consistent and use default value of slots=True.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

…l OL usages

Signed-off-by: Kacper Muda <mudakacper@gmail.com>
Copy link
Contributor

@JDarDagran JDarDagran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kacpermuda for addressing your concerns!

@mobuchowski mobuchowski merged commit 10f2503 into apache:main Jul 24, 2024
52 checks passed
@kacpermuda kacpermuda deleted the ol-slots-fix branch July 24, 2024 12:55
molcay pushed a commit to VladaZakharova/airflow that referenced this pull request Aug 19, 2024
…l OL usages (apache#40992)

Signed-off-by: Kacper Muda <mudakacper@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants