DatabricksPlugin - Fix dag view redirect URL by using url_for redirect #41040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajkoti
changed the title
uranusjr
approved these changes
Jul 26, 2024
ephraimbuddy
approved these changes
Jul 26, 2024
potiuk
approved these changes
Jul 26, 2024
|
Thanks a lot to @TJaniF for testing and reporting this issue 🙏🏽 |
molcay
pushed a commit
to VladaZakharova/airflow
that referenced
this pull request
Aug 19, 2024
apache#41040) We observed that the redirect does not work well on deployments that are not rooted at "/". Following the pattern of using the flask helper url_for in our other views, it resolves this issue and redirects to the dag view page now work well with this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We observed that the redirect does not work well on deployments
that are not rooted at "/". Following the pattern of using the
flask helper
url_forin our other views, it resolves this issue andredirects to the dag view page now work well with this fix.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.