Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Databricks Provider] Revert PRs #40864 and #40471 #41050

Merged
merged 2 commits into from
Jul 27, 2024

Conversation

pankajkoti
Copy link
Member

This reverts PR #40864 and PR #40471.

Previously, PR #40471 was contributed to address issue #35433.
However, that contribution gave rise to another issue #40788.
Next #40788 was being attempted to be resolved in PR #40864.
However, with the second PR, it appears that the previous old
issue #35433 has resurfaced. So, at the moment, the case is
that we have 2 PRs on top of the existing implementation
eventually having nil effect and the previous issues persists.
I believe it is better to revert those 2 PRs, reopen the earlier
issue #35433 and peacefully address it by taking the needed time.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@pankajkoti
Copy link
Member Author

pankajkoti commented Jul 26, 2024

cc: @boraberke for your information. I guess it would be better if we rework on the earlier issue peacefully and clear the path for the upcoming release. Hope you're comfortable with the approach :)

@pankajkoti pankajkoti requested a review from eladkal July 26, 2024 13:35
@boraberke
Copy link
Contributor

cc: @boraberke for your information. I guess it would be better if we rework on the earlier issue peacefully and clear the path for the upcoming release. Hope you're comfortable with the approach :)

Sure, thanks for letting me know! I did not have enough time to check if the issue has resurfaced or not. Maybe even it will be better if someone who's more experienced or have used these operators can fix it in a cleaner way :)

@pankajkoti pankajkoti merged commit 4535e08 into apache:main Jul 27, 2024
52 checks passed
@pankajkoti pankajkoti deleted the revert-pr-40864-pr-40471 branch July 27, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants