Add dataset alias unique constraint and remove wrong dataset alias removing logic #41097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:db-migrations
Lee-W
force-pushed
the
add-dataset-alias-unique-constraint
branch
from
7abed49
to
fa66210
Compare
airflow/migrations/versions/0151_2_10_0_dataset_alias_unique_constraint.py
Outdated
Show resolved
Hide resolved
Lee-W
force-pushed
the
add-dataset-alias-unique-constraint
branch
2 times, most recently
from
0e62e00
to
20ae5aa
Compare
ephraimbuddy
approved these changes
Jul 30, 2024
…aset alias uniqueness but remove removing checking logic
…se test_bulk_write_to_db_dataset_aliases
Lee-W
force-pushed
the
add-dataset-alias-unique-constraint
branch
from
20ae5aa
to
b1ee453
Compare
uranusjr
reviewed
Jul 30, 2024
uranusjr
reviewed
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
What
DatasetAliasModelDatasetAlias. It now works ok, but the unique dataset aliases will accumulate. I'm thinking of doing something similar toTaskOutletDatasetAliasReferenceand will create another PR for it.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.