-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-2568] Azure Container Instances operator #4121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments
airflow/contrib/operators/azure_container_instances_operator.py
Outdated
Show resolved
Hide resolved
airflow/contrib/operators/azure_container_instances_operator.py
Outdated
Show resolved
Hide resolved
Updated PR, thanks for the comments @Fokko! Let me know if there is anything else I can fix |
Codecov Report
@@ Coverage Diff @@
## master #4121 +/- ##
===========================================
+ Coverage 16.13% 78.11% +61.98%
===========================================
Files 202 202
Lines 16483 16484 +1
===========================================
+ Hits 2660 12877 +10217
+ Misses 13823 3607 -10216
Continue to review full report at Codecov.
|
a74f41e
to
c65dc8b
Compare
Removed extra line and rebased onto master so it is all up to date. Thanks @Fokko |
|
||
def __init__(self, conn_id='azure_registry'): | ||
self.conn_id = conn_id | ||
self.connection = self.get_conn() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like self.connection gets used inside azure_container_instances_operator.py
when setting up the registry hook. Is there something else I am missing here? Design is a bit confusing admittedly as this was code I picked up from an existing PR so if there is some best practice here to change the code please let me know
c65dc8b
to
5464a86
Compare
Apologies for the bad iteration after splitting out the files @Fokko . Everything should be up to date now and I have verified the docs are updated and verified the scenario works end-to-end. Let me know if there is anything else (particularly with the one remaining unresolved comment) |
5464a86
to
b0b6c9c
Compare
Noticed there were some merge conflicts in integration.rst since last week so I fixed that and pushed again |
Flaky tests caused a build failure, could somebody with write access restart the job that failed? It passed in our forked repo so doesn't look like a code failure: Otherwise I can close and re-open PR or rebase again once there are new commits |
b0b6c9c
to
a4f27cb
Compare
Rebased again to get a new build. @Fokko, please take a look when you get a chance, hope it is ready to go. Thanks! |
Could you please add tests for the hook, too? :) |
3c0e3a0
to
5aa8a7a
Compare
Add an operator to create a Docker container in Azure Container Instances. Azure Container Instances hosts a container and abstracts away the infrastructure around orchestration of a container service. Operator supports creating an ACI container and pull an image from Azure Container Registry or public Docker registries.
5aa8a7a
to
0b6dea0
Compare
Thanks to all the previous commenters! The PR has now been updated to include full unit testing for all the hooks. I have also rebased against the latest master and pulled in the connections.py changes. Thanks @Fokko and @feluelle for the comments, please review when you get a chance. Happy holidays! |
Add an operator to create a Docker container in Azure Container Instances. Azure Container Instances hosts a container and abstracts away the infrastructure around orchestration of a container service. Operator supports creating an ACI container and pull an image from Azure Container Registry or public Docker registries.
Add an operator to create a Docker container in Azure Container Instances. Azure Container Instances hosts a container and abstracts away the infrastructure around orchestration of a container service. Operator supports creating an ACI container and pull an image from Azure Container Registry or public Docker registries.
Add an operator to create a Docker container in Azure Container Instances. Azure Container Instances hosts a container and abstracts away the infrastructure around orchestration of a container service. Operator supports creating an ACI container and pull an image from Azure Container Registry or public Docker registries.
Add an operator to create a Docker container in Azure Container Instances. Azure Container Instances hosts a container and abstracts away the infrastructure around orchestration of a container service. Operator supports creating an ACI container and pull an image from Azure Container Registry or public Docker registries.
Add an operator to create a Docker container in Azure Container
Instances. Azure Container Instances hosts a container and abstracts
away the infrastructure around orchestration of a container service.
Operator supports creating an ACI container and pull an image from Azure
Container Registry or public Docker registries.
This PR takes the great work @NielsZeilemaker did with #3467 and fixes it to work
with the latest Azure SDK as well as adding an example DAG and some
minor correlating fixes.
Make sure you have checked all steps below.
Jira
Description
An Azure Container Instances operator which allows you to run/monitor containers on ACI
Tests
Commits
Documentation
Code Quality
flake8