Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics basic deprecated validators removed in favor of pattern matching #41975

Merged
merged 5 commits into from
Sep 17, 2024
Merged

Metrics basic deprecated validators removed in favor of pattern matching #41975

merged 5 commits into from
Sep 17, 2024

Conversation

dirrao
Copy link
Contributor

@dirrao dirrao commented Sep 3, 2024

Metrics basic deprecated validators (AllowListValidator and BlockListValidator) removed in favor of pattern matching

@dirrao dirrao self-assigned this Sep 3, 2024
@dirrao dirrao added area:metrics airflow3.0:candidate Potential candidates for Airflow 3.0 airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes labels Sep 3, 2024
ferruzzi
ferruzzi requested changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@ferruzzi ferruzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am so happy to see these deprecation PRs actually removing stuff!

Left an easy change request/suggestion, otherwise LGTM.

Those unit tests were somewhat convoluted, nice work sorting through them.

airflow/metrics/validators.py Outdated Show resolved Hide resolved
airflow/metrics/validators.py Outdated Show resolved Hide resolved
tests/core/test_stats.py Show resolved Hide resolved
tests/core/test_stats.py Outdated Show resolved Hide resolved
@dirrao dirrao requested a review from ferruzzi September 4, 2024 05:33
ferruzzi
ferruzzi approved these changes Sep 4, 2024
View reviewed changes
tests/core/test_stats.py Show resolved Hide resolved
airflow/metrics/validators.py Show resolved Hide resolved
@dirrao dirrao requested a review from eladkal September 5, 2024 06:32
@dirrao
Copy link
Contributor Author

dirrao commented Sep 10, 2024

@potiuk / @eladkal
I'm awaiting final approval to proceed with the merge. Could you please take a look when you get a chance?

@potiuk
Copy link
Member

potiuk commented Sep 11, 2024

Needs to resolve conflict now.

@dirrao
Copy link
Contributor Author

dirrao commented Sep 12, 2024

Needs to resolve conflict now.

Done.

@dirrao dirrao requested a review from potiuk September 16, 2024 05:46
@dirrao
Copy link
Contributor Author

dirrao commented Sep 17, 2024

@eladkal
I'm waiting for the final review and merge.

@ferruzzi ferruzzi merged commit dfbdb3c into apache:main Sep 17, 2024
51 checks passed
joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
@dirrao @joaopamaral
Metrics basic deprecated validators removed in favor of pattern match…
ebb62ca 
…ing (apache#41975)

* metrics basic deprecated validators removed

* metrics basic deprecated validators removed

* news fragment added
@Lee-W Lee-W mentioned this pull request Nov 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferruzzi ferruzzi ferruzzi approved these changes

@uranusjr uranusjr Awaiting requested review from uranusjr

@eladkal eladkal Awaiting requested review from eladkal

@potiuk potiuk Awaiting requested review from potiuk

Assignees

@dirrao dirrao

Labels
airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes airflow3.0:candidate Potential candidates for Airflow 3.0 area:metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dirrao @potiuk @ferruzzi