Make SAML a required dependency of Amazon provider #42137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:dev-tools
area:providers
area:system-tests
provider:amazon-aws
potiuk
changed the title
Amazon provider with auth manager requires SAML onelogin import and it starts to be more and more problematic to skip the related tests for compatibility. It seems appropriate to move saml to be a required dependency of Amazon provider in this case. Since saml is only used by Amazon provider, we can also safely remove optional extra for it.
potiuk
force-pushed
the
move-saml-to-amazon-provider-dependency
branch
from
eaabbec
to
e8670ed
Compare
hussein-awala
approved these changes
Sep 10, 2024
eladkal
reviewed
Sep 10, 2024
| @@ -57,6 +57,7 @@ dependencies: | |||
| - ipykernel | |||
| - pandas>=2.1.2,<2.2;python_version>="3.9" | |||
| - pandas>=1.5.3,<2.2;python_version<"3.9" | |||
| - python3-saml>=1.16.0 | |||
There was a problem hiding this comment.
In the description you mentioned its being used inly by Amazon provider. If so why do we need it in papermill?
There was a problem hiding this comment.
Only in Amazon not Papermill - that was typed to fast when I was in a hurry for Airflow Summit :)
There was a problem hiding this comment.
what a mistake. Thanks for noticing it :)
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Sep 10, 2024
Follow up after apache#42137 -> saml was added mistakenly to papermill, not amazon :(
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
Amazon provider with auth manager requires SAML onelogin import and it starts to be more and more problematic to skip the related tests for compatibility. It seems appropriate to move saml to be a required dependency of Amazon provider in this case. Since saml is only used by Amazon provider, we can also safely remove optional extra for it.
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
…apache#42148) Follow up after apache#42137 -> saml was added mistakenly to papermill, not amazon :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amazon provider with auth manager requires SAML onelogin import and it starts to be more and more problematic to skip the related tests for compatibility.
It seems appropriate to move saml to be a required dependency of Amazon provider in this case.
Since saml is only used by Amazon provider, we can also safely remove optional extra for it.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.