Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestTranslationLegacyModelPredictLink dataset_id error for google provider translation operator #42463

Merged

Conversation

olegkachur-e
Copy link
Contributor

  • Add dataset_id parameter to let TestTranslationLegacyModelPredictLink work with the translation model.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Sep 25, 2024
@olegkachur-e olegkachur-e force-pushed the fix_predict_operator_for_translate branch 2 times, most recently from 2589cbc to 56bcecb Compare September 30, 2024 14:48
@potiuk
Copy link
Member

potiuk commented Oct 2, 2024

cc: @VladaZakharova ?

@VladaZakharova
Copy link
Contributor

cc: @VladaZakharova ?

yes, LGTM

@olegkachur-e olegkachur-e force-pushed the fix_predict_operator_for_translate branch 5 times, most recently from 9b71b24 to ab6597c Compare October 17, 2024 09:58
- Add dataset_id parameter to let TestTranslationLegacyModelPredictLink
work with the translation model.
@olegkachur-e olegkachur-e force-pushed the fix_predict_operator_for_translate branch from ab6597c to 0fed6a8 Compare October 17, 2024 11:12
@potiuk potiuk merged commit aeb7e90 into apache:main Oct 17, 2024
55 checks passed
harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
)

- Add dataset_id parameter to let TestTranslationLegacyModelPredictLink
work with the translation model.

Co-authored-by: Oleg Kachur <kachur@google.com>
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
)

- Add dataset_id parameter to let TestTranslationLegacyModelPredictLink
work with the translation model.

Co-authored-by: Oleg Kachur <kachur@google.com>
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
)

- Add dataset_id parameter to let TestTranslationLegacyModelPredictLink
work with the translation model.

Co-authored-by: Oleg Kachur <kachur@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants