fix(datasets/managers): fix error handling file loc when dataset alias resolved into new datasets #42733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
changed the title
vincbeck
approved these changes
Oct 4, 2024
shahar1
reviewed
Oct 4, 2024
eladkal
approved these changes
Oct 6, 2024
Lee-W
force-pushed
the
fix-dataset-alias-dag-prority-request
branch
4 times, most recently
from
d7ee817
to
308d9f4
Compare
…resolved into new datasets
Lee-W
force-pushed
the
fix-dataset-alias-dag-prority-request
branch
from
308d9f4
to
475e0e7
Compare
shahar1
approved these changes
Oct 7, 2024
shahar1
added
type:bug-fix
|
Changing the milestone since this one is the backport PR. |
uranusjr
reviewed
Oct 7, 2024
uranusjr
approved these changes
Oct 7, 2024
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
uranusjr
approved these changes
Oct 8, 2024
utkarsharma2
pushed a commit
that referenced
this pull request
Oct 23, 2024
…as resolved into new datasets (#42733) * fix(datasets/managers): fix error handling fileloc when datasetalias resolved into new datasets * test(datasets/manager): add test case test_register_dataset_change_with_alias * refactor(datasets/manager): simplify for loop Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> --------- Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
utkarsharma2
pushed a commit
that referenced
this pull request
Oct 24, 2024
…as resolved into new datasets (#42733) * fix(datasets/managers): fix error handling fileloc when datasetalias resolved into new datasets * test(datasets/manager): add test case test_register_dataset_change_with_alias * refactor(datasets/manager): simplify for loop Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> --------- Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
This was referenced Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Detailed in #42704. values should be list of dict instead of dict
What
Pass a list of file locations as a dictionary for DAG priority parsing request when dataset aliases are resolved into new datasets.
Closes: #42704
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.