Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for the PowerBIDatasetRefresh Operator. #42754

Merged
merged 12 commits into from
Oct 24, 2024

Conversation

ambika-garg
Copy link
Contributor

This PR intends to add the documentation like Connection types, Operators for the Power BI Dataset Refresh Operator in Apache Airflow Site.
Refer to: https://airflow.apache.org/docs/apache-airflow-providers-microsoft-azure/10.5.0/_api/airflow/providers/microsoft/azure/operators/powerbi/index.html


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member

potiuk commented Oct 5, 2024

static checks failing - there is some inconistency in the provider.yaml

@ambika-garg
Copy link
Contributor Author

I've resolved the static checks. Could you please review it.

@Lee-W
Copy link
Member

Lee-W commented Oct 11, 2024

I think we'll need to resolve conflict again due to newly merged PR

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good in general but some merge conflict artefacts seems to be left-over.

Generally Good to merge but add this marker not to merge by accident.

tests/providers/__init__.py Outdated Show resolved Hide resolved
dev/breeze/tests/test_pytest_args_for_test_types.py Outdated Show resolved Hide resolved
@ambika-garg ambika-garg requested a review from jscheffl October 24, 2024 12:14
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup! Very pretty now!

@jscheffl jscheffl merged commit 64336c2 into apache:main Oct 24, 2024
56 checks passed
@ambika-garg ambika-garg deleted the powerbi-docs branch October 24, 2024 19:50
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
* Add documentation for PowerBI Dataset Refresh Operator

* Add the link to powerbi documentation in operator class

* Refactor rst files

* Add how-to-guide in provider.yaml

* add files created in create-missing-init-py-files-tests hook

* Fix to pass breeze unit tests

* Fix to pass breeze unit tests

* Fix operator documentation path

* remove pre-commit generated files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants