Add kubernetes_conn_id to templated fields #42786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gopidesupavan
requested review from
jedcunningham and
hussein-awala
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
gopidesupavan
requested review from
romsharon98,
hussein-awala and
jedcunningham
and removed request for
hussein-awala and
jedcunningham
romsharon98
approved these changes
Oct 6, 2024
gopidesupavan
force-pushed
the
add-kube-conn-id-to-templated-fields
branch
from
61c8eea to
ff63c8a
Compare
|
Verified the failure tests are not related to this. |
gopidesupavan
force-pushed
the
add-kube-conn-id-to-templated-fields
branch
from
ff63c8a to
4ad6e20
Compare
romsharon98
reviewed
Oct 13, 2024
providers/src/airflow/providers/cncf/kubernetes/operators/spark_kubernetes.py
Show resolved
Hide resolved
romsharon98
approved these changes
Oct 16, 2024
gopidesupavan
force-pushed
the
add-kube-conn-id-to-templated-fields
branch
from
4ad6e20 to
f890798
Compare
R7L208
pushed a commit
to R7L208/airflow
that referenced
this pull request
Oct 17, 2024
harjeevanmaan
pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
PaulKobow7536
pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
83 tasks
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue, user has working
kubernetes_conn_idwith jinja fields with 2.5.3 version. I don't have this version to re produce. so not sure entirely how its getting resolved on this versions.Am able to produce this on the latest versions
kubernetes_conn_idconnection id is not resolving when jinja fields provided, IMO it should be added to templated fields.closes: #42546
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.