Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop python3.8 support core and providers - v2.10 backport #42788

Open
wants to merge 2 commits into
base: v2-10-test
Choose a base branch
from
Open

Drop python3.8 support core and providers - v2.10 backport #42788

wants to merge 2 commits into from

Conversation

jscheffl
Copy link
Contributor

@jscheffl jscheffl commented Oct 6, 2024 •
edited
Loading

Back-port of #42766 for v2-10

as lazy consensus as in https://lists.apache.org/thread/8wcx310km11poox5rc4pz24ttgsdllw9 passed... preparing this for Airflow 2.11

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:CLI area:core-operators Operators, Sensors and hooks within Core Airflow area:dev-tools area:logging area:production-image Production image improvements and fixes area:providers area:serialization area:webserver Webserver related Issues provider:amazon-aws AWS/Amazon - related issues provider:cloudant provider:cncf-kubernetes Kubernetes provider related issues provider:common-io provider:openlineage AIP-53 labels Oct 6, 2024
@jscheffl jscheffl changed the title Feature/drop python3.8 support core and providers v2 10 backport Drop python3.8 support core and providers - v2.10 backport Oct 6, 2024
@jscheffl
Copy link
Contributor Author

jscheffl commented Oct 7, 2024

Mis-understood the docs/apache-airflow/installation/supported-versions.rst:55 - no backport...

@jscheffl jscheffl closed this Oct 7, 2024
@jscheffl jscheffl deleted the feature/drop-python3.8-support-core-and-providers-v2-10-backport branch October 7, 2024 18:06
@jscheffl jscheffl mentioned this pull request Oct 9, 2024
Merged
@jscheffl jscheffl restored the feature/drop-python3.8-support-core-and-providers-v2-10-backport branch October 9, 2024 17:01
@jscheffl jscheffl reopened this Oct 9, 2024
@jscheffl jscheffl added this to the Airflow 2.11.0 milestone Oct 9, 2024
@jscheffl
Copy link
Contributor Author

jscheffl commented Oct 9, 2024

@potiuk for getting this into 2.11... in dev/README_AIRFLOW3_DEV.md there is no definition... which target merge branch to be used as "parking lot" for 2.11? Is v2-10-testcorrect? There is no v2-11-test and no v2-test....

@jscheffl
Copy link
Contributor Author

jscheffl commented Oct 9, 2024

Note before merge: Last 3 commits from PR #42766 are not on this back-port (yet). Backport was cut before review completed.

@jscheffl jscheffl mentioned this pull request Oct 16, 2024
Closed
@jscheffl jscheffl force-pushed the feature/drop-python3.8-support-core-and-providers-v2-10-backport branch 2 times, most recently from 274876f to 0416d55 Compare October 19, 2024 21:36
@jscheffl
Copy link
Contributor Author

Note before merge: Last 3 commits from PR #42766 are not on this back-port (yet). Backport was cut before review completed.

DONE.

@potiuk potiuk mentioned this pull request Oct 23, 2024
Merged
@potiuk
Copy link
Member

potiuk commented Oct 23, 2024 •
edited
Loading

Just as a comment to remind in the future - python version in the check_python_version script from #43282 (back-ported in #43310) will also need to be updated before we merge it

@jscheffl jscheffl force-pushed the feature/drop-python3.8-support-core-and-providers-v2-10-backport branch from 0416d55 to 682ec12 Compare October 23, 2024 21:13
@jscheffl
Copy link
Contributor Author

Just as a comment to remind in the future - python version in the check_python_version script from #43282 (back-ported in #43310) will also need to be updated before we merge it

Thanks fr the hint, added this in this PR in last commit. DONE

@jscheffl jscheffl force-pushed the feature/drop-python3.8-support-core-and-providers-v2-10-backport branch from 682ec12 to 60974c4 Compare October 24, 2024 19:20
@jscheffl jscheffl marked this pull request as ready for review October 26, 2024 20:51
@potiuk
Copy link
Member

potiuk commented Oct 26, 2024

Will have to wait for the 2.11 cut-off I guess.

jscheffl
jscheffl commented Oct 26, 2024
View reviewed changes
.readthedocs.yml
@@ -20,7 +20,7 @@ formats: []
sphinx:
configuration: docs/rtd-deprecation/conf.py
python:
version: "3.8"
version: "3.9"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a marker preventing to merge. Please merge only once Airflow 2.11 cut-off is made.
This PR should NOT go into Airflow 2.10

@jscheffl jscheffl force-pushed the feature/drop-python3.8-support-core-and-providers-v2-10-backport branch from 60974c4 to 8ef2fce Compare November 14, 2024 21:57
@jscheffl @kaxil
Drop python3.8 support core and providers - v2.10 backport
a855e70 
Add newsfragment

(cherry picked from commit f0c14e7)
(cherry picked from commit 1638974)

Integrated changes from PR #43310

migrate last 3 commits from original PR

Fix pytests of breeze

Fix constraints problem with cloudant in python 3.9

(cherry picked from commit 4375185)

Fix static checks for providers and core

Fix selective checks

(cherry picked from commit 1b55c8e)

Drop Python 3.8 support in provider packages

(cherry picked from commit 5de5ca7)
(cherry picked from commit 526948f)
@kaxil kaxil force-pushed the feature/drop-python3.8-support-core-and-providers-v2-10-backport branch from 8ef2fce to a855e70 Compare December 17, 2024 15:19
@kaxil
Copy link
Member

kaxil commented Dec 17, 2024

@jscheffl Could you verify your changes again -- I needed to force-push on v2-10-test to sync it back with v2-10-stable.

@jscheffl
Copy link
Contributor Author

@jscheffl Could you verify your changes again -- I needed to force-push on v2-10-test to sync it back with v2-10-stable.

Uuf, I think I can do this later. But if you want to force-push to v2-10-test I see no problem. I need to re-base this PR anyway. Just go ahead and I'll re-base and check later. (Anyway I assume it is a bit of a moving target until 2.11 is not on the table and blocks this PR from being merged)

@kaxil
Copy link
Member

kaxil commented Dec 17, 2024

@jscheffl Could you verify your changes again -- I needed to force-push on v2-10-test to sync it back with v2-10-stable.

Uuf, I think I can do this later. But if you want to force-push to v2-10-test I see no problem. I need to re-base this PR anyway. Just go ahead and I'll re-base and check later. (Anyway I assume it is a bit of a moving target until 2.11 is not on the table and blocks this PR from being merged)

I have done that already :) and rebased your PR too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolkedebruin bolkedebruin Awaiting requested review from bolkedebruin bolkedebruin is a code owner

@eladkal eladkal Awaiting requested review from eladkal eladkal is a code owner

@kaxil kaxil Awaiting requested review from kaxil kaxil is a code owner

@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun pierrejeambrun is a code owner

@potiuk potiuk Awaiting requested review from potiuk potiuk is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

@o-nikolas o-nikolas Awaiting requested review from o-nikolas o-nikolas is a code owner

@mobuchowski mobuchowski Awaiting requested review from mobuchowski mobuchowski is a code owner

@hussein-awala hussein-awala Awaiting requested review from hussein-awala hussein-awala is a code owner

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@bbovenzi bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner

@XD-DENG XD-DENG Awaiting requested review from XD-DENG XD-DENG is a code owner

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy

@dstandish dstandish Awaiting requested review from dstandish

@uranusjr uranusjr Awaiting requested review from uranusjr

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area:API Airflow's REST/HTTP API area:CLI area:core-operators Operators, Sensors and hooks within Core Airflow area:dev-tools area:logging area:production-image Production image improvements and fixes area:providers area:serialization area:webserver Webserver related Issues provider:amazon-aws AWS/Amazon - related issues provider:cloudant provider:cncf-kubernetes Kubernetes provider related issues provider:common-io provider:openlineage AIP-53
Projects
None yet
Milestone
Airflow 2.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jscheffl @potiuk @kaxil