-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed conf property from str to dict in SparkSqlOperator #42835
Changed conf property from str to dict in SparkSqlOperator #42835
Conversation
@duhizjame the changes looks good. |
also what do you think about supporting both |
@romsharon98 maybe its better that way, so we don't break everyone on versions <= 4.8.2, I will add it to the PR tonight regarding version changes: thanks for the feedback! :) |
I think that for features we need to change nothing belongs to the provider.yml, I think we have a bot that add the documentation according to the PR title/commit and the version will update by the release manager when we releasing the package. |
I have no idea why the pipeline fails to build images, I haven't used breeze to dev/test |
You have conflicts that need to be resolved. |
91e1fbf
to
27f29e8
Compare
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Changes the conf property from str to dict in SparkSqlOperator
closes: #40507
The previous PR was closed due to inactivity, I had time this week to fix it