-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix retry configuration in k8s tests #42871
Merged
potiuk
merged 1 commit into
apache:main
from
gopidesupavan:fix-k8s-test-request-lib-retry-config
Oct 9, 2024
Merged
Fix retry configuration in k8s tests #42871
potiuk
merged 1 commit into
apache:main
from
gopidesupavan:fix-k8s-test-request-lib-retry-config
Oct 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
provider:cncf-kubernetes
Kubernetes provider related issues
label
Oct 9, 2024
gopidesupavan
requested review from
potiuk,
romsharon98,
amoghrajesh and
shahar1
October 9, 2024 18:10
potiuk
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NICE and SIMPLE. Love it.
kunaljubce
pushed a commit
to kunaljubce/airflow
that referenced
this pull request
Oct 13, 2024
pavansharma36
pushed a commit
to pavansharma36/airflow
that referenced
this pull request
Oct 14, 2024
gopidesupavan
added a commit
to gopidesupavan/airflow
that referenced
this pull request
Oct 14, 2024
gopidesupavan
added a commit
to gopidesupavan/airflow
that referenced
this pull request
Oct 15, 2024
romsharon98
pushed a commit
that referenced
this pull request
Oct 15, 2024
R7L208
pushed a commit
to R7L208/airflow
that referenced
this pull request
Oct 17, 2024
utkarsharma2
pushed a commit
that referenced
this pull request
Oct 23, 2024
harjeevanmaan
pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
PaulKobow7536
pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
utkarsharma2
pushed a commit
that referenced
this pull request
Oct 24, 2024
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the retry configuration with
status_forcelist
andallowed_methods
.By default, the retry configuration's
status_forcelist
is set to None, meaning no action is taken when an error response is received.Additionally, the default
allowed_methods
does not include the PATCH and POST methods. In k8s test, API endpoints use the PATCH and POST methods for the following routes:api/v1/dags/{dag_id}
: PATCHapi/v1/dags/{dag_id}/dagRuns
: POSThttps://urllib3.readthedocs.io/en/stable/reference/urllib3.util.html#urllib3.util.Retry
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.