Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retry configuration in k8s tests #42871

Merged

Conversation

gopidesupavan
Copy link
Member

@gopidesupavan gopidesupavan commented Oct 9, 2024

Updating the retry configuration with status_forcelist and allowed_methods.

By default, the retry configuration's status_forcelist is set to None, meaning no action is taken when an error response is received.

Additionally, the default allowed_methods does not include the PATCH and POST methods. In k8s test, API endpoints use the PATCH and POST methods for the following routes:

api/v1/dags/{dag_id}: PATCH
api/v1/dags/{dag_id}/dagRuns: POST

https://urllib3.readthedocs.io/en/stable/reference/urllib3.util.html#urllib3.util.Retry


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the provider:cncf-kubernetes Kubernetes provider related issues label Oct 9, 2024
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE and SIMPLE. Love it.

@potiuk potiuk merged commit 8a4e7bd into apache:main Oct 9, 2024
64 checks passed
kunaljubce pushed a commit to kunaljubce/airflow that referenced this pull request Oct 13, 2024
pavansharma36 pushed a commit to pavansharma36/airflow that referenced this pull request Oct 14, 2024
gopidesupavan added a commit to gopidesupavan/airflow that referenced this pull request Oct 14, 2024
@potiuk potiuk added this to the Airflow 2.10.3 milestone Oct 15, 2024
gopidesupavan added a commit to gopidesupavan/airflow that referenced this pull request Oct 15, 2024
R7L208 pushed a commit to R7L208/airflow that referenced this pull request Oct 17, 2024
harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
@gopidesupavan gopidesupavan deleted the fix-k8s-test-request-lib-retry-config branch November 23, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:cncf-kubernetes Kubernetes provider related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants