-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for Kubernetes package version 31.0.0 #42907
Conversation
Mypy check fixed in main. Merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well. Actually - not really. 31.0.0 is the latest version and we do not use any features from it. It's a bit dangerous to bump lower binding of a dependency - especially if what's left is just one current version - because it will force update to that version even if som eone would like to keep previous one (for example for comopatibility reasons or because there is a bug found in the latest version).
Our constraints are automatically updated to latest version - and pip
or uv
will generally use latest available version by default, so any new installations or "reproducible" airflow upgrades using constraints will use the latest version by default but the user will still have a chance of downgrading it in case of a bug or incompatibility.
We currently have "lowest-direct" CI job - it will check if we are using any of the new features when running tests - so it should automatically detect cases when we should bump the "lower-bounded" libraries, and with that, I think we should generally only bump the lower bounds when it fails (or when the developer bumped lower binding because they know that they are using some newer features.
So I guess @dirrao we should close this one. |
The title is mis leading. I have updated it. This PR will add the support for Kubernetes package version 31.0.0 without changing existing min version support. |
Yah. Checks are braking after PR merge #42539 |
They are actually breaking after new release of microsoft's kioto package few hours ago. but yes - that's it. |
Right. Stupid me 🤯 - > but you mislead me with the title so 1:1 😄 |
Adding support for Kubernetes package version 31.0.0