Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Kubernetes package version 31.0.0 #42907

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

dirrao
Copy link
Contributor

@dirrao dirrao commented Oct 10, 2024

Adding support for Kubernetes package version 31.0.0

@boring-cyborg boring-cyborg bot added area:providers provider:cncf-kubernetes Kubernetes provider related issues labels Oct 10, 2024
@dirrao dirrao self-assigned this Oct 10, 2024
@dirrao dirrao requested review from potiuk and eladkal October 10, 2024 16:38
@potiuk
Copy link
Member

potiuk commented Oct 15, 2024

Mypy check fixed in main. Merging.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well. Actually - not really. 31.0.0 is the latest version and we do not use any features from it. It's a bit dangerous to bump lower binding of a dependency - especially if what's left is just one current version - because it will force update to that version even if som eone would like to keep previous one (for example for comopatibility reasons or because there is a bug found in the latest version).

Our constraints are automatically updated to latest version - and pip or uv will generally use latest available version by default, so any new installations or "reproducible" airflow upgrades using constraints will use the latest version by default but the user will still have a chance of downgrading it in case of a bug or incompatibility.

We currently have "lowest-direct" CI job - it will check if we are using any of the new features when running tests - so it should automatically detect cases when we should bump the "lower-bounded" libraries, and with that, I think we should generally only bump the lower bounds when it fails (or when the developer bumped lower binding because they know that they are using some newer features.

@potiuk
Copy link
Member

potiuk commented Oct 15, 2024

So I guess @dirrao we should close this one.

@dirrao dirrao changed the title Kubernetes package version bump to 31.0.0 Adding support for Kubernetes package version 31.0.0 Oct 15, 2024
@dirrao
Copy link
Contributor Author

dirrao commented Oct 15, 2024

So I guess @dirrao we should close this one.

The title is mis leading. I have updated it. This PR will add the support for Kubernetes package version 31.0.0 without changing existing min version support.

@dirrao dirrao requested a review from potiuk October 15, 2024 03:56
@dirrao
Copy link
Contributor Author

dirrao commented Oct 15, 2024

Mypy check fixed in main. Merging.

Yah. Checks are braking after PR merge #42539

@potiuk
Copy link
Member

potiuk commented Oct 15, 2024

Mypy check fixed in main. Merging.

Yah. Checks are braking after PR merge #42539

They are actually breaking after new release of microsoft's kioto package few hours ago. but yes - that's it.

@potiuk
Copy link
Member

potiuk commented Oct 15, 2024

The title is mis leading. I have updated it. This PR will add the support for Kubernetes package version 31.0.0 without changing existing min version support.

Right. Stupid me 🤯 - > but you mislead me with the title so 1:1 😄

@potiuk potiuk merged commit 2eaa90f into apache:main Oct 15, 2024
100 of 101 checks passed
R7L208 pushed a commit to R7L208/airflow that referenced this pull request Oct 17, 2024
harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:cncf-kubernetes Kubernetes provider related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants