Allow python 3.12 for the breeze release commands #42936
Conversation
I'm not 100% sure why we added this check in the first place, but it doesn't seem to be needed anymore (I've tested things locally with this removed and it all seems to behave itself)
|
It's just a matter of looking it up in git blame. Actually this is not really good idea for now (Provider's release manager's releasing providers should not use Python 3.12). it's all visible in detail in history of those changed lines. What can actually be removed now is the 3.9 check (because we do not use Python 3.8 any more and python 3.8 produced non-reproducible builds as explained in comments and in #37401). \ Python 3.12 was excluded (additionally) here #37615 because some of our provider packages did not support 3.12 and as of recently as part of release process we are building .sdist packages and they cannot be build for packages that do not support Python 3.12. Currently apache-beam does not support Python 3.12 yet (mostly because they embedded dill version that breaks our PythonVirtualenvOperator as explained in #41990 and we cannot enabvle it until apache/beam#32617 is fixed. But yeah. It makes no sense to block 3.12 usage for everyone, it might be enough to remove it for providers release command only. I will correct it. |
Follow up after apache#42766 and apache#42936. * We do not have to check for minimum Python version for Python 3.9 any more (as we do not support 3.8 any more) * While Python 3.12 is not yet fully supported by Apache Beam, we should still not allow it for releasing providers, but all other commands should support Python 3.12 * When you had pre-commit installed with Python 3.8 before, various errors might appear when running pre-commit. Troubleshooting was added quoting the errors and explaining what to do.
|
Better fix in #42944 |
Follow up after #42766 and #42936. * We do not have to check for minimum Python version for Python 3.9 any more (as we do not support 3.8 any more) * While Python 3.12 is not yet fully supported by Apache Beam, we should still not allow it for releasing providers, but all other commands should support Python 3.12 * When you had pre-commit installed with Python 3.8 before, various errors might appear when running pre-commit. Troubleshooting was added quoting the errors and explaining what to do.
Not really, not to me anyway -- I found the PR #37615 before opening this but that didn't actually give me any further clues as to what the actual problem using Py 3.12 was. |
I'm not 100% sure why we added this check in the first place, but it doesn't seem to be needed anymore (I've tested things locally with this removed and it all seems to behave itself)
Follow up after apache#42766 and apache#42936. * We do not have to check for minimum Python version for Python 3.9 any more (as we do not support 3.8 any more) * While Python 3.12 is not yet fully supported by Apache Beam, we should still not allow it for releasing providers, but all other commands should support Python 3.12 * When you had pre-commit installed with Python 3.8 before, various errors might appear when running pre-commit. Troubleshooting was added quoting the errors and explaining what to do.
I'm not 100% sure why we added this check in the first place, but it doesn't seem to be needed anymore (I've tested things locally with this removed and it all seems to behave itself)
Follow up after apache#42766 and apache#42936. * We do not have to check for minimum Python version for Python 3.9 any more (as we do not support 3.8 any more) * While Python 3.12 is not yet fully supported by Apache Beam, we should still not allow it for releasing providers, but all other commands should support Python 3.12 * When you had pre-commit installed with Python 3.8 before, various errors might appear when running pre-commit. Troubleshooting was added quoting the errors and explaining what to do.
I'm not 100% sure why we added this check in the first place, but it doesn't
seem to be needed anymore (I've tested things locally with this removed and it
all seems to behave itself)