Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make google provider pyarrow dependency explicit #42996

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

saucoide
Copy link
Contributor

The provider already depends on it directly but it was not listed in provider.yaml, this MR only adds pyarrow to it

Closes: #42924

The provider already depends on it directly but it was not listed in provider.yaml
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Oct 14, 2024
Copy link

boring-cyborg bot commented Oct 14, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented Oct 15, 2024

However you also need to run pre-commit on that change - to get the "provider_dependencies.json" generated for you.

@saucoide
Copy link
Contributor Author

However you also need to run pre-commit on that change - to get the "provider_dependencies.json" generated for you.

done

@eladkal eladkal changed the title Make google provider pyarrow dependency explicit GH#42924 Make google provider pyarrow dependency explicit Oct 15, 2024
@potiuk
Copy link
Member

potiuk commented Oct 15, 2024

the failing check is about kiota new version (same in main) - it will be addressed shortly. Merging.

@potiuk potiuk merged commit 732e056 into apache:main Oct 15, 2024
100 of 101 checks passed
Copy link

boring-cyborg bot commented Oct 15, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

R7L208 pushed a commit to R7L208/airflow that referenced this pull request Oct 17, 2024
* Make google provider pyarrow dependency explicit

The provider already depends on it directly but it was not listed in provider.yaml

* Add comment to the change

* rerun hooks
harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
* Make google provider pyarrow dependency explicit

The provider already depends on it directly but it was not listed in provider.yaml

* Add comment to the change

* rerun hooks
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
* Make google provider pyarrow dependency explicit

The provider already depends on it directly but it was not listed in provider.yaml

* Add comment to the change

* rerun hooks
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
* Make google provider pyarrow dependency explicit

The provider already depends on it directly but it was not listed in provider.yaml

* Add comment to the change

* rerun hooks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing pyarrow dependency in google provider?
3 participants