-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vertex ai training operators: add display_name to rendered fields #43028
vertex ai training operators: add display_name to rendered fields #43028
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
For the future - you can add "Closes: #ISSUE_NUMBER" to the commit message and it will automatically link the issue you created and it will close it - saves a lot of duplicated effort. Also - for such things we do not really need an issue - just open PR and add description what it does - we do not really like overhead and unnecessary |
f698fd3
to
4a55c3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
There was a static check error due to current limitations of the validate-operators-init
static check: the templated fields should be defined in the constructor's signature and explicitly assigned via super().__init__(param=param, ...)
or self.param = params
- even in inherited classes.
I rebased and pushed the fix.
4a55c3c
to
2d01221
Compare
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
…ache#43028) * vertex ai training operators: add display_name to rendered fields * fix validate-operators-init static checks --------- Co-authored-by: Walter Hoekstra <walterhoekstra@bol.com> Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
…ache#43028) * vertex ai training operators: add display_name to rendered fields * fix validate-operators-init static checks --------- Co-authored-by: Walter Hoekstra <walterhoekstra@bol.com> Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
…ache#43028) * vertex ai training operators: add display_name to rendered fields * fix validate-operators-init static checks --------- Co-authored-by: Walter Hoekstra <walterhoekstra@bol.com> Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
…ache#43028) * vertex ai training operators: add display_name to rendered fields * fix validate-operators-init static checks --------- Co-authored-by: Walter Hoekstra <walterhoekstra@bol.com> Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
Add display_name and model_display_name to list of rendered fields for Vertex AI operators.