Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlSensor enhancement: #37437 #43107

Merged
merged 1 commit into from
Oct 17, 2024
Merged

SqlSensor enhancement: #37437 #43107

merged 1 commit into from
Oct 17, 2024

Conversation

vVv-AA
Copy link
Contributor

@vVv-AA vVv-AA commented Oct 17, 2024

Allow SqlSensor to inspect the entire result row by adding a selector field.
This is useful to customize the success/failure criteria instead of just the first cell.
closes: #37437


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link

boring-cyborg bot commented Oct 17, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Allow SqlSensor to inspect the entire result row by adding a selector field.
This is useful to customize the success/failure criteria instead of just the first cell.
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one.

@potiuk potiuk merged commit b86bb24 into apache:main Oct 17, 2024
55 checks passed
Copy link

boring-cyborg bot commented Oct 17, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
Allow SqlSensor to inspect the entire result row by adding a selector field.
This is useful to customize the success/failure criteria instead of just the first cell.

Co-authored-by: Jasmin <jasmin.a.patel13@gmail.com>
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
Allow SqlSensor to inspect the entire result row by adding a selector field.
This is useful to customize the success/failure criteria instead of just the first cell.

Co-authored-by: Jasmin <jasmin.a.patel13@gmail.com>
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
Allow SqlSensor to inspect the entire result row by adding a selector field.
This is useful to customize the success/failure criteria instead of just the first cell.

Co-authored-by: Jasmin <jasmin.a.patel13@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlSensor parameter fails to capture the replication lag
2 participants