Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TimeoutError to be a retryable error in databricks provider #43137

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Add TimeoutError to be a retryable error in databricks provider #43137

merged 2 commits into from
Oct 18, 2024

Conversation

rawwar
Copy link
Collaborator

@rawwar rawwar commented Oct 18, 2024 •
edited
Loading

closes #43128

aiohttp.client_exception.ServerTimeoutError extends asyncio.exceptions.TimeoutError. Hence, used ServerTimeoutError when checking for type using isinstance. That should cover TimeoutError

@rawwar rawwar marked this pull request as ready for review October 18, 2024 02:47
@rawwar rawwar requested review from Lee-W and pankajkoti October 18, 2024 02:48
@rawwar
Copy link
Collaborator Author

rawwar commented Oct 18, 2024

@lucafurrer , FYI

pankajkoti
pankajkoti reviewed Oct 18, 2024
View reviewed changes
Copy link
Member

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If ServerTimeoutError extends TimeoutError, we should check for TimeoutError instead. It works the other way round than what we're saying the description🙂

@rawwar

This comment was marked as off-topic.

Sign in to view
@pankajkoti pankajkoti merged commit 0de5587 into apache:main Oct 18, 2024
55 checks passed
@rawwar rawwar deleted the kalyan/providers/databricks/retryable_timeout_error branch October 18, 2024 07:57
harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
@rawwar @harjeevanmaan
Add TimeoutError to be a retryable error in databricks provider (apac…
d8f3fd9 
…he#43137)

closes apache#43128
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
@rawwar @PaulKobow7536
Add TimeoutError to be a retryable error in databricks provider (apac…
7f2e696 
…he#43137)

closes apache#43128
@eladkal eladkal mentioned this pull request Oct 27, 2024
Closed
83 tasks
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
@rawwar @ellisms
Add TimeoutError to be a retryable error in databricks provider (apac…
bdeb272 
…he#43137)

closes apache#43128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pankajkoti pankajkoti pankajkoti approved these changes

@Lee-W Lee-W Lee-W approved these changes

Assignees
No one assigned
Labels
area:providers provider:databricks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add TimeoutError to be a retryable error in databricks provider
3 participants
@rawwar @Lee-W @pankajkoti