nit: remove taskgroup's tooltip from OL's AirflowJobFacet #43152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kacpermuda
force-pushed
the
nit-ol-remove-tooltip
branch
from
ea1f73a to
8b5ab8b
Compare
potiuk
force-pushed
the
nit-ol-remove-tooltip
branch
from
8b5ab8b to
712e769
Compare
|
Rebased. |
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
kacpermuda
force-pushed
the
nit-ol-remove-tooltip
branch
from
712e769 to
f515a2c
Compare
mobuchowski
approved these changes
Oct 22, 2024
harjeevanmaan
pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
PaulKobow7536
pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
83 tasks
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing TaskGroup's tooltip from AirflowJobFacet that's included in DAG start event. The tooltip is already included in task level OpenLineage events and it might be long (docstring for taskflow API functions), so there is no need to duplicate that information. The DAG start event should only contain information necessary to deduce task dependencies and DAG structure, so the tooltip is not needed at that time.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.