Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More correctly work around uv sync issue with python 3.10+ only dep #43227

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

ashb
Copy link
Member

@ashb ashb commented Oct 21, 2024

Just having the python_version requirement doesn't seem to correctly make uv
"fork" the resolver path (Charlie's words/terms), so we either need to specify
both module versions here. The other option that could work is putting this in
our pyproject.toml

[tool.uv]
environments = ["python_version >= '3.10'", "python_version < '3.10'"]

But having both versions specified keeps the fix localized into the provider
so I have chosen this approach.

This is likely why the exclued-python-version setting we already had wasn't working for uv sync.

Just having the python_version requirement doesn't seem to correctly make uv
"fork" the resolver path (Charlie's words/terms), so we either need to specify
both module versions here. The other option that could work is putting this in
our pyproject.toml

```
[tool.uv]
environments = ["python_version >= '3.10'", "python_version < '3.10'"]
```

But having both versions specified keeps the fix localized into the provider
so I have chosen this approach
@ashb ashb merged commit db6e103 into main Oct 21, 2024
83 of 105 checks passed
@ashb ashb deleted the uv-sync-ibmcloudant-urllib3-deps branch October 21, 2024 19:41
harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
…apache#43227)

Just having the python_version requirement doesn't seem to correctly make uv
"fork" the resolver path (Charlie's words/terms), so we either need to specify
both module versions here. The other option that could work is putting this in
our pyproject.toml

```
[tool.uv]
environments = ["python_version >= '3.10'", "python_version < '3.10'"]
```

But having both versions specified keeps the fix localized into the provider
so I have chosen this approach.

This is likely why the exclued-python-version setting we already had wasn't
working for uv sync.


astral-sh/uv#4668
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
…apache#43227)

Just having the python_version requirement doesn't seem to correctly make uv
"fork" the resolver path (Charlie's words/terms), so we either need to specify
both module versions here. The other option that could work is putting this in
our pyproject.toml

```
[tool.uv]
environments = ["python_version >= '3.10'", "python_version < '3.10'"]
```

But having both versions specified keeps the fix localized into the provider
so I have chosen this approach.

This is likely why the exclued-python-version setting we already had wasn't
working for uv sync.


astral-sh/uv#4668
@charliermarsh
Copy link
Contributor

@ashb -- This should be fixed in the next uv release, I just tested it.

@charliermarsh
Copy link
Contributor

See: astral-sh/uv#8628

@kaxil kaxil mentioned this pull request Oct 28, 2024
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
…apache#43227)

Just having the python_version requirement doesn't seem to correctly make uv
"fork" the resolver path (Charlie's words/terms), so we either need to specify
both module versions here. The other option that could work is putting this in
our pyproject.toml

```
[tool.uv]
environments = ["python_version >= '3.10'", "python_version < '3.10'"]
```

But having both versions specified keeps the fix localized into the provider
so I have chosen this approach.

This is likely why the exclued-python-version setting we already had wasn't
working for uv sync.


astral-sh/uv#4668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants