Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade FAB to 4.5.1 #43251

Merged
merged 1 commit into from
Oct 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions airflow/www/security_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,9 @@ def before_request():
g.user = get_auth_manager().get_user()

def create_limiter(self) -> Limiter:
limiter = Limiter(key_func=get_remote_address)
limiter.init_app(self.appbuilder.get_app)
app = self.appbuilder.get_app
limiter = Limiter(key_func=app.config.get("RATELIMIT_KEY_FUNC", get_remote_address))
limiter.init_app(app)
return limiter

def register_views(self):
Expand Down
6 changes: 3 additions & 3 deletions dev/breeze/tests/test_packages.py
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ def test_get_documentation_package_path():
"""
"apache-airflow-providers-common-compat>=1.2.1",
"apache-airflow>=2.9.0",
"flask-appbuilder==4.5.0",
"flask-appbuilder==4.5.1",
"flask-login>=0.6.2",
"flask>=2.2,<2.3",
"google-re2>=1.0",
Expand All @@ -183,7 +183,7 @@ def test_get_documentation_package_path():
"""
"apache-airflow-providers-common-compat>=1.2.1.dev0",
"apache-airflow>=2.9.0.dev0",
"flask-appbuilder==4.5.0",
"flask-appbuilder==4.5.1",
"flask-login>=0.6.2",
"flask>=2.2,<2.3",
"google-re2>=1.0",
Expand All @@ -197,7 +197,7 @@ def test_get_documentation_package_path():
"""
"apache-airflow-providers-common-compat>=1.2.1b0",
"apache-airflow>=2.9.0b0",
"flask-appbuilder==4.5.0",
"flask-appbuilder==4.5.1",
"flask-login>=0.6.2",
"flask>=2.2,<2.3",
"google-re2>=1.0",
Expand Down
2 changes: 1 addition & 1 deletion generated/provider_dependencies.json
Original file line number Diff line number Diff line change
Expand Up @@ -572,7 +572,7 @@
"deps": [
"apache-airflow-providers-common-compat>=1.2.1",
"apache-airflow>=2.9.0",
"flask-appbuilder==4.5.0",
"flask-appbuilder==4.5.1",
"flask-login>=0.6.2",
"flask>=2.2,<2.3",
"google-re2>=1.0",
Expand Down
2 changes: 1 addition & 1 deletion providers/src/airflow/providers/fab/provider.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ dependencies:
# Every time we update FAB version here, please make sure that you review the classes and models in
# `airflow/providers/fab/auth_manager/security_manager/override.py` with their upstream counterparts.
# In particular, make sure any breaking changes, for example any new methods, are accounted for.
- flask-appbuilder==4.5.0
- flask-appbuilder==4.5.1
- flask-login>=0.6.2
- google-re2>=1.0
- jmespath>=0.7.0
Expand Down
Loading