Skip example importability tests for providers in non-main branches #43260

potiuk · 2024-10-22T11:41:57Z

When "Always" tests are running in v2* branches, they also tested provider examples for importability. However sometimes those tests failed because we have not cherry-picked some of the provider's changes that were necessary for the examples to get imported.

This PR excludes provider's examples from the "always" running importability tests, when the branch we are running it in is not main (i.e. we are in one of the past v2-branches).

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

When "Always" tests are running in v2* branches, they also tested provider examples for importability. However sometimes those tests failed because we have not cherry-picked some of the provider's changes that were necessary for the examples to get imported. This PR excludes provider's examples from the "always" running importability tests, when the branch we are running it in is not main (i.e. we are in one of the past v2-branches).

…pache#43260) When "Always" tests are running in v2* branches, they also tested provider examples for importability. However sometimes those tests failed because we have not cherry-picked some of the provider's changes that were necessary for the examples to get imported. This PR excludes provider's examples from the "always" running importability tests, when the branch we are running it in is not main (i.e. we are in one of the past v2-branches). (cherry picked from commit 0f38be1)

While the apache#43260 attempted to address the problem where example dag importability tests should skip provider tests on non-main, it did not actually solve the problem. While debugging it, it turned out that since apache#42505, the provider tests were not executed in main "at all" - the "providers" directory was not included in the list of places to check for the example dags (they were in "airflow" in v2-10-test") this is why it "looked like" the solution worked in "main". This PR fixes both problems: * brings back importability of provider's example_dags in main branch * properly excludes the providers examples in non-main branch

…43260) (#43263) When "Always" tests are running in v2* branches, they also tested provider examples for importability. However sometimes those tests failed because we have not cherry-picked some of the provider's changes that were necessary for the examples to get imported. This PR excludes provider's examples from the "always" running importability tests, when the branch we are running it in is not main (i.e. we are in one of the past v2-branches). (cherry picked from commit 0f38be1)

While the #43260 attempted to address the problem where example dag importability tests should skip provider tests on non-main, it did not actually solve the problem. While debugging it, it turned out that since #42505, the provider tests were not executed in main "at all" - the "providers" directory was not included in the list of places to check for the example dags (they were in "airflow" in v2-10-test") this is why it "looked like" the solution worked in "main". This PR fixes both problems: * brings back importability of provider's example_dags in main branch * properly excludes the providers examples in non-main branch

…43273) While the apache#43260 attempted to address the problem where example dag importability tests should skip provider tests on non-main, it did not actually solve the problem. While debugging it, it turned out that since apache#42505, the provider tests were not executed in main "at all" - the "providers" directory was not included in the list of places to check for the example dags (they were in "airflow" in v2-10-test") this is why it "looked like" the solution worked in "main". This PR fixes both problems: * brings back importability of provider's example_dags in main branch * properly excludes the providers examples in non-main branch

…43260) (#43263) When "Always" tests are running in v2* branches, they also tested provider examples for importability. However sometimes those tests failed because we have not cherry-picked some of the provider's changes that were necessary for the examples to get imported. This PR excludes provider's examples from the "always" running importability tests, when the branch we are running it in is not main (i.e. we are in one of the past v2-branches). (cherry picked from commit 0f38be1)

…#43307) While the #43260 attempted to address the problem where example dag importability tests should skip provider tests on non-main, it did not actually solve the problem. While debugging it, it turned out that since #42505, the provider tests were not executed in main "at all" - the "providers" directory was not included in the list of places to check for the example dags (they were in "airflow" in v2-10-test") this is why it "looked like" the solution worked in "main". This PR fixes both problems: * brings back importability of provider's example_dags in main branch * properly excludes the providers examples in non-main branch

…pache#43260) When "Always" tests are running in v2* branches, they also tested provider examples for importability. However sometimes those tests failed because we have not cherry-picked some of the provider's changes that were necessary for the examples to get imported. This PR excludes provider's examples from the "always" running importability tests, when the branch we are running it in is not main (i.e. we are in one of the past v2-branches).

…43273) While the apache#43260 attempted to address the problem where example dag importability tests should skip provider tests on non-main, it did not actually solve the problem. While debugging it, it turned out that since apache#42505, the provider tests were not executed in main "at all" - the "providers" directory was not included in the list of places to check for the example dags (they were in "airflow" in v2-10-test") this is why it "looked like" the solution worked in "main". This PR fixes both problems: * brings back importability of provider's example_dags in main branch * properly excludes the providers examples in non-main branch

…pache#43260) When "Always" tests are running in v2* branches, they also tested provider examples for importability. However sometimes those tests failed because we have not cherry-picked some of the provider's changes that were necessary for the examples to get imported. This PR excludes provider's examples from the "always" running importability tests, when the branch we are running it in is not main (i.e. we are in one of the past v2-branches).

…43273) While the apache#43260 attempted to address the problem where example dag importability tests should skip provider tests on non-main, it did not actually solve the problem. While debugging it, it turned out that since apache#42505, the provider tests were not executed in main "at all" - the "providers" directory was not included in the list of places to check for the example dags (they were in "airflow" in v2-10-test") this is why it "looked like" the solution worked in "main". This PR fixes both problems: * brings back importability of provider's example_dags in main branch * properly excludes the providers examples in non-main branch

…43260) (#43263) When "Always" tests are running in v2* branches, they also tested provider examples for importability. However sometimes those tests failed because we have not cherry-picked some of the provider's changes that were necessary for the examples to get imported. This PR excludes provider's examples from the "always" running importability tests, when the branch we are running it in is not main (i.e. we are in one of the past v2-branches). (cherry picked from commit 0f38be1)

…#43307) While the #43260 attempted to address the problem where example dag importability tests should skip provider tests on non-main, it did not actually solve the problem. While debugging it, it turned out that since #42505, the provider tests were not executed in main "at all" - the "providers" directory was not included in the list of places to check for the example dags (they were in "airflow" in v2-10-test") this is why it "looked like" the solution worked in "main". This PR fixes both problems: * brings back importability of provider's example_dags in main branch * properly excludes the providers examples in non-main branch

…pache#43260) When "Always" tests are running in v2* branches, they also tested provider examples for importability. However sometimes those tests failed because we have not cherry-picked some of the provider's changes that were necessary for the examples to get imported. This PR excludes provider's examples from the "always" running importability tests, when the branch we are running it in is not main (i.e. we are in one of the past v2-branches).

…43273) While the apache#43260 attempted to address the problem where example dag importability tests should skip provider tests on non-main, it did not actually solve the problem. While debugging it, it turned out that since apache#42505, the provider tests were not executed in main "at all" - the "providers" directory was not included in the list of places to check for the example dags (they were in "airflow" in v2-10-test") this is why it "looked like" the solution worked in "main". This PR fixes both problems: * brings back importability of provider's example_dags in main branch * properly excludes the providers examples in non-main branch

potiuk requested review from ephraimbuddy, kaxil, utkarsharma2, aritra24, romsharon98, eladkal and jscheffl October 22, 2024 11:42

romsharon98 approved these changes Oct 22, 2024

View reviewed changes

ephraimbuddy approved these changes Oct 22, 2024

View reviewed changes

utkarsharma2 approved these changes Oct 22, 2024

View reviewed changes

eladkal approved these changes Oct 22, 2024

View reviewed changes

potiuk added this to the Airflow 2.10.3 milestone Oct 22, 2024

potiuk merged commit 0f38be1 into apache:main Oct 22, 2024
49 checks passed

potiuk deleted the skip-importing-providers-examples-in-non-main-branches branch October 22, 2024 12:06

potiuk mentioned this pull request Oct 22, 2024

Skip example importability tests for providers in non-main branches (… #43263

Merged

potiuk mentioned this pull request Oct 22, 2024

Fixes behaviour of example dag tests for main/other branches #43273

Merged

potiuk mentioned this pull request Oct 23, 2024

Fixes behaviour of example dag tests for main/other branches (#43273) #43307

Merged

This was referenced Oct 28, 2024

Status of testing of Apache Airflow 2.10.3rc2 #43441

Closed

Status of testing of Apache Airflow 2.10.3rc2 #43585

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Skip example importability tests for providers in non-main branches #43260

Skip example importability tests for providers in non-main branches #43260

potiuk commented Oct 22, 2024

Skip example importability tests for providers in non-main branches #43260

Skip example importability tests for providers in non-main branches #43260

Conversation

potiuk commented Oct 22, 2024