Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a debug log for creating batch workloads in dataproc #43265

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

romsharon98
Copy link
Contributor

@romsharon98 romsharon98 commented Oct 22, 2024

suppress:#41812
related: #41789


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Oct 22, 2024
@kaxil
Copy link
Member

kaxil commented Oct 23, 2024

@romsharon98 Could you please update the PR title? The current one is a bit vague and doesn’t clearly communicate the purpose of the change. I recommend reading this blog post for guidance.

In particular, it would be helpful to follow this principle:

A properly formed Git commit subject line should always be able to complete the following sentence: “If applied, this commit will [your subject line here].”

Since this entry will appear in the release notes, it’s important that the PR title and description clearly explain the changes and their impact.

@romsharon98 romsharon98 changed the title Feature/debug log for google Add a debug log for creating batch workloads in dataproc Oct 25, 2024
@romsharon98
Copy link
Contributor Author

@romsharon98 Could you please update the PR title? The current one is a bit vague and doesn’t clearly communicate the purpose of the change. I recommend reading this blog post for guidance.

In particular, it would be helpful to follow this principle:

A properly formed Git commit subject line should always be able to complete the following sentence: “If applied, this commit will [your subject line here].”

Since this entry will appear in the release notes, it’s important that the PR title and description clearly explain the changes and their impact.

Thanks @kaxil really appreciate the informative comment.
I changed the PR title accordingly

@potiuk potiuk merged commit b4363f4 into apache:main Oct 25, 2024
58 checks passed
@romsharon98 romsharon98 deleted the feature/debug-log-for-google branch October 25, 2024 21:18
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants