Made usage of Path explicit for Edge Worker pid files #43308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AutomationDev85
approved these changes
Oct 23, 2024
OliverWannenwetsch
force-pushed
the
bugfix/321279-edge-worker-pid-file-not-handled-as-path-type
branch
from
b31c5e5 to
41e64ca
Compare
jscheffl
approved these changes
Oct 23, 2024
harjeevanmaan
pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
* Made usage of Path explicit for Edge Worker pid files * Updated version number of Edge Worker provider package * Fixed pytests by findings of mypy
PaulKobow7536
pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
* Made usage of Path explicit for Edge Worker pid files * Updated version number of Edge Worker provider package * Fixed pytests by findings of mypy
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
* Made usage of Path explicit for Edge Worker pid files * Updated version number of Edge Worker provider package * Fixed pytests by findings of mypy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a type confusion in the pid file path in the Edge worker.
Now, pid_file_path is explicitly treated as string in the entire implementation of the Edge Worker cli, which interfaces with the lib
lockfile.pidlockfilefor pid file interaction, consuming file path as string onlyChanges in Detail
edge_commandpid_file_pathof class_EdgeWorkerClifromPathtostr