-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DatabricksHook: fix status property to work with ClientResponse used in async mode #43333
DatabricksHook: fix status property to work with ClientResponse used in async mode #43333
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
Can you please add/modify a unit test for it to avoid regression? |
Sure, I will try |
@lucafurrer , if you would like some help, I can write the test case for this. Thanks for fixing it. |
@rawwar Hi, I will not have time before tonight to look into it. If you want go for it. |
Won't be able to do it right now. But, i can finish this in this week |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
…in async mode (apache#43333) * fix status property to work with ClientResponse used in async mode in Databricks Hook * add unittest for Databricks async api call
closes: #43269
The object returned in by
request_func
in the_a_do_api_call
is not arequest.Response
as in the synchronous call but aClientResponse
which does not have the propertystatus_code
butstatus
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.