Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dag Page header #43362

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Conversation

bbovenzi
Copy link
Contributor

Use the Dag Details public API to render a basic header for the DAG Details page.
Also fixed tags and dags list filter labels to match designs better.

Built on top of #43324

Only look at the last commit.

Screenshot 2024-10-24 at 3 08 06 PM Screenshot 2024-10-24 at 3 07 40 PM Screenshot 2024-10-24 at 3 07 47 PM

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Oct 24, 2024
@bbovenzi bbovenzi marked this pull request as draft October 24, 2024 19:10
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Just the selector for cards/list on the dags overview seems to be broken :-(
image

@bbovenzi bbovenzi force-pushed the aip-38-dag-page-header branch 2 times, most recently from 11992fd to efc4b92 Compare October 25, 2024 16:37
@bbovenzi bbovenzi marked this pull request as ready for review October 25, 2024 18:41
@bbovenzi bbovenzi force-pushed the aip-38-dag-page-header branch from efc4b92 to f7b11ee Compare October 25, 2024 19:38
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@pierrejeambrun pierrejeambrun merged commit 393a584 into apache:main Oct 28, 2024
52 checks passed
@pierrejeambrun pierrejeambrun deleted the aip-38-dag-page-header branch October 28, 2024 08:41
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
* Add ability to select a dag from dags list

* Fix event propagation and onRowClicked type

* Remove div links and only show error stack trace in dev

* use get dag details to build header for Dag Page

* Rebase fix and move semantic color gen to a function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants