Add context to Azure Service Bus Message callback #43370
Conversation
boring-cyborg
bot
added
area:providers
provider:microsoft-azure
perry2of5
force-pushed
the
pass-ctxt-to-azure-svc-bus-msg-callback-43361-inspect
branch
from
8793230 to
2e3b446
Compare
Indeed. Can you please add a note on top of the changelog for the provider explaining the breaking change and what the users should do to switch? |
perry2of5
force-pushed
the
pass-ctxt-to-azure-svc-bus-msg-callback-43361-inspect
branch
from
2e3b446 to
b5a3685
Compare
|
Added note. Thanks for letting me know what to do. |
perry2of5
force-pushed
the
pass-ctxt-to-azure-svc-bus-msg-callback-43361-inspect
branch
2 times, most recently
from
8763be9 to
b9807d6
Compare
|
Hmmm...the contributing guide says "update the provider.yaml file with the new (breaking) version of the provider", but the provider.yaml says "note that those versions are maintained by release manager - do not update them manually". I assume I don't need to change provider.yaml and that putting my comment about the breaking change in the PR is enough. Is that true? |
|
Yes. No need to update versions, just update changelog - and any clarifications in our contributing docs are also very good contributions (just saying!) |
|
Built provider locally and tested end-to-end in flow. Everything worked as expected. |
The original callback only took the message as a paramter. However, users may want to push status or location information into XComs and so callbacks need access to the context (or the XComs, but context is more general). This commit changes the code to pass the context NOTE: This is a BREAKING CHANGE. Fixes 43361
perry2of5
force-pushed
the
pass-ctxt-to-azure-svc-bus-msg-callback-43361-inspect
branch
from
b9807d6 to
d62e12e
Compare
perry2of5
deleted the
pass-ctxt-to-azure-svc-bus-msg-callback-43361-inspect
branch
* Add context to Azure Service Bus Message callback The original callback only took the message as a paramter. However, users may want to push status or location information into XComs and so callbacks need access to the context (or the XComs, but context is more general). This commit changes the code to pass the context NOTE: This is a BREAKING CHANGE. Fixes 43361 * Add breaking change note to CHANGELOG
The original callback only took the message as a parameter. However, users may want to push status or location information into XComs and so callbacks need access to the context (or the XComs, but context is more general). This commit changes the code to pass the context.
NOTE: This is a BREAKING CHANGE.
Closes #43361