Add logging to the migration commands #43516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR enhances logging for the migration commands and ensures that alembic doesn't change the logger when logging. A PR was raised to address the issue of reset db command changing logging level; see f166467, but that did not address it for other commands. This PR addresses it for all the migration commands
jedcunningham
approved these changes
Oct 30, 2024
hussein-awala
approved these changes
Oct 30, 2024
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
potiuk
approved these changes
Oct 31, 2024
25 tasks
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
* Add logging to the migration commands This PR enhances logging for the migration commands and ensures that alembic doesn't change the logger when logging. A PR was raised to address the issue of reset db command changing logging level; see f166467, but that did not address it for other commands. This PR addresses it for all the migration commands * fixup! Add logging to the migration commands * Apply suggestions from code review Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> --------- Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances logging for the migration commands and ensures that
alembic doesn't change the logger when logging.
A PR was raised to address the issue of reset db command changing logging level;
see f166467, but that did not address
it for other commands. This PR addresses it for all the migration commands