Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch PythonVirtualenvOperator to venv from virtualenv package #43568

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Oct 31, 2024

The PythonVirtualenvOperator has been using virtualenv in order to support Python 2.7 and pre Python 3.5, however we do not need those any more - and we can use built-in venv instead.

Fixes: #40420


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good! LGTM!

@gopidesupavan
Copy link
Member

cool :)

@potiuk potiuk force-pushed the replace-virtualenv-with-venv branch from b7ead64 to 9efc4bf Compare November 1, 2024 11:33
The PythonVirtualenvOperator has been using virtualenv in order
to support Python 2.7 and pre Python 3.5, however we do not need
those any more - and we can use built-in venv instead.

Fixes: apache#40420
@potiuk potiuk force-pushed the replace-virtualenv-with-venv branch from 9efc4bf to cd39453 Compare November 1, 2024 11:36
@potiuk potiuk merged commit fe0dd9b into apache:main Nov 1, 2024
108 checks passed
@potiuk potiuk deleted the replace-virtualenv-with-venv branch November 1, 2024 13:03
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
…he#43568)

The PythonVirtualenvOperator has been using virtualenv in order
to support Python 2.7 and pre Python 3.5, however we do not need
those any more - and we can use built-in venv instead.

Fixes: apache#40420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PythonVirtualOperator fails silently when virtualenv is not installed.
4 participants