-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move triggers to standard provider #43608
Move triggers to standard provider #43608
Conversation
fd4715c
to
f314194
Compare
These changes also require to support 2.8 and 2.9, will wait for this #43556 and then rebase on top so that will fix if anything fails for 2.8 and 2.9. Meanwhile working on local and verifying to support these changes on 2.8 and 2.9 :) |
Yeah ... Some of #43556 take a bit more than I originally anticipated :D |
Yeah fine no rush |
f314194
to
23d0b29
Compare
3f8c3f2
to
7c2a56d
Compare
d0b8345
to
97368da
Compare
e3ebdbd
to
5864f75
Compare
This is green now, one test failed not related to this. would anyone have another look on the latest modifications, mostly those are test fixes to support compatibility :) |
* move triggers to standard provider * move triggers to standard provider * remove tests/triggers * fix static checks * ignore TaskSuccessEvent for 2.8 and 2.9 versions * fix compat tests related to logical dates and TaskSuccessEvent * fix test_external_task test * move sensor helper inside standard provider * fix external task test
Move triggers to standard provider
airflow/triggers/external_task.py
airflow/triggers/file.py
airflow/triggers/temporal.py
to
providers/src/airflow/providers/standard/triggers/external_task.py
providers/src/airflow/providers/standard/triggers/file.py
providers/src/airflow/providers/standard/triggers/temporal.py
related #43641
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.