Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move triggers to standard provider #43608

Merged

Conversation

gopidesupavan
Copy link
Member

@gopidesupavan gopidesupavan commented Nov 2, 2024

Move triggers to standard provider

airflow/triggers/external_task.py
airflow/triggers/file.py
airflow/triggers/temporal.py

to

providers/src/airflow/providers/standard/triggers/external_task.py
providers/src/airflow/providers/standard/triggers/file.py
providers/src/airflow/providers/standard/triggers/temporal.py

related #43641


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@gopidesupavan
Copy link
Member Author

These changes also require to support 2.8 and 2.9, will wait for this #43556 and then rebase on top so that will fix if anything fails for 2.8 and 2.9.

Meanwhile working on local and verifying to support these changes on 2.8 and 2.9 :)

@potiuk
Copy link
Member

potiuk commented Nov 4, 2024

These changes also require to support 2.8 and 2.9, will wait for this #43556 and then rebase on top so that will fix if anything fails for 2.8 and 2.9.

Meanwhile working on local and verifying to support these changes on 2.8 and 2.9 :)

Yeah ... Some of #43556 take a bit more than I originally anticipated :D

@gopidesupavan
Copy link
Member Author

These changes also require to support 2.8 and 2.9, will wait for this #43556 and then rebase on top so that will fix if anything fails for 2.8 and 2.9.
Meanwhile working on local and verifying to support these changes on 2.8 and 2.9 :)

Yeah ... Some of #43556 take a bit more than I originally anticipated :D

Yeah fine no rush ☺️...

@gopidesupavan gopidesupavan force-pushed the move-triggers-standard-provider branch from f314194 to 23d0b29 Compare November 10, 2024 08:23
@gopidesupavan gopidesupavan force-pushed the move-triggers-standard-provider branch 2 times, most recently from 3f8c3f2 to 7c2a56d Compare November 17, 2024 17:25
@gopidesupavan gopidesupavan force-pushed the move-triggers-standard-provider branch 2 times, most recently from d0b8345 to 97368da Compare November 22, 2024 15:39
@gopidesupavan gopidesupavan force-pushed the move-triggers-standard-provider branch from e3ebdbd to 5864f75 Compare November 24, 2024 21:19
@gopidesupavan
Copy link
Member Author

This is green now, one test failed not related to this. would anyone have another look on the latest modifications, mostly those are test fixes to support compatibility :)

@gopidesupavan gopidesupavan merged commit 4404e64 into apache:main Nov 25, 2024
135 of 136 checks passed
@gopidesupavan gopidesupavan deleted the move-triggers-standard-provider branch November 25, 2024 19:05
LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
* move triggers to standard provider

* move triggers to standard provider

* remove tests/triggers

* fix static checks

* ignore TaskSuccessEvent for 2.8 and 2.9 versions

* fix compat tests related to logical dates and TaskSuccessEvent

* fix test_external_task test

* move sensor helper inside standard provider

* fix external task test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants