Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT Fix Incorrect FutureWarning in 2,10 #44061

Closed
wants to merge 1 commit into from
Closed

MAINT Fix Incorrect FutureWarning in 2,10 #44061

wants to merge 1 commit into from

Conversation

SuccessMoses
Copy link
Contributor

Fixes #43794

In airflow version 2.10, removed deprecation warning for sql_alchemy_conn and others in [core] instead of [database] in airflow.cfg

@SuccessMoses SuccessMoses marked this pull request as draft November 15, 2024 14:41
@potiuk
Copy link
Member

potiuk commented Nov 16, 2024

It's not the right fix. Rather than removing the old values from deprecated list, we should suppress the warnings in this particular case where we check for sensitive values.

@zachliu
Copy link
Contributor

zachliu commented Nov 16, 2024

It's not the right fix. Rather than removing the old values from deprecated list, we should suppress the warnings in this particular case where we check for sensitive values.

isn't this my bandit fix? 😁 i just added with self.suppress_future_warnings(): before

airflow/airflow/configuration.py

Line 859 in c99887e

value = self.get(section, key, suppress_warnings=True)

@potiuk
Copy link
Member

potiuk commented Nov 16, 2024

isn't this my bandit fix? 😁 i just added with self.suppress_future_warnings(): before

Yep. That's what it should be

zachliu added a commit to zachliu/airflow that referenced this pull request Nov 18, 2024
@zachliu
suppress the warnings in this particular case where we check for sens…
3835b18 
…itive values

apache#44061 (comment)
zachliu added a commit to zachliu/airflow that referenced this pull request Nov 18, 2024
@zachliu
suppress the warnings where we check for sensitive values
3daa821 
apache#44061 (comment)
@zachliu zachliu mentioned this pull request Nov 18, 2024
Merged
@zachliu
Copy link
Contributor

zachliu commented Nov 18, 2024

suppress the warnings in this particular case where we check for sensitive values.

okie doke

#44148

potiuk pushed a commit that referenced this pull request Nov 19, 2024
@zachliu
suppress the warnings where we check for sensitive values (#44148)
9eaeb1c 
#44061 (comment)
github-actions bot pushed a commit that referenced this pull request Nov 19, 2024
@zachliu
[v2-10-test] suppress the warnings where we check for sensitive values (
56c3e2b 
#44148)

(cherry picked from commit 9eaeb1c)

Co-authored-by: Zach Liu <zachliu@users.noreply.github.com>
https: //github.com//pull/44061#issuecomment-2480320259
@github-actions github-actions bot mentioned this pull request Nov 19, 2024
Merged
potiuk pushed a commit that referenced this pull request Nov 19, 2024
@github-actions @zachliu
[v2-10-test] suppress the warnings where we check for sensitive values (
a58ed9d 
#44148) (#44167)

(cherry picked from commit 9eaeb1c)


https: //github.com//pull/44061#issuecomment-2480320259

Co-authored-by: Zach Liu <zachliu@users.noreply.github.com>
@potiuk potiuk closed this Nov 19, 2024
@potiuk
Copy link
Member

potiuk commented Nov 19, 2024

Closing. Fixed by #44148

utkarsharma2 pushed a commit that referenced this pull request Dec 4, 2024
@github-actions @zachliu @utkarsharma2
[v2-10-test] suppress the warnings where we check for sensitive values (
257848d 
#44148) (#44167)

(cherry picked from commit 9eaeb1c)


https: //github.com//pull/44061#issuecomment-2480320259

Co-authored-by: Zach Liu <zachliu@users.noreply.github.com>
utkarsharma2 pushed a commit that referenced this pull request Dec 9, 2024
@github-actions @zachliu @utkarsharma2
[v2-10-test] suppress the warnings where we check for sensitive values (
86e0da8 
#44148) (#44167)

(cherry picked from commit 9eaeb1c)


https: //github.com//pull/44061#issuecomment-2480320259

Co-authored-by: Zach Liu <zachliu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SuccessMoses @potiuk @zachliu