Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-84: Migrating GET queued asset events for assets to FASTAPI #44139

Merged

Conversation

vatsrahul1001
Copy link
Collaborator

Related: #42370


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Nov 18, 2024
@vatsrahul1001 vatsrahul1001 added the legacy api Whether legacy API changes should be allowed in PR label Nov 18, 2024
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice a couple of small suggestions, should be good to merge.

airflow/api_fastapi/core_api/routes/public/assets.py Outdated Show resolved Hide resolved
airflow/api_fastapi/core_api/routes/public/assets.py Outdated Show resolved Hide resolved
vatsrahul1001 and others added 3 commits November 18, 2024 20:30
Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
…nomer/airflow into AIP84-get-assets-queued-events-new
@vatsrahul1001 vatsrahul1001 force-pushed the AIP84-get-assets-queued-events-new branch from 9523dbc to 05c9f72 Compare November 19, 2024 09:36
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@pierrejeambrun pierrejeambrun merged commit 39042c8 into apache:main Nov 19, 2024
62 checks passed
@pierrejeambrun pierrejeambrun deleted the AIP84-get-assets-queued-events-new branch November 19, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. legacy api Whether legacy API changes should be allowed in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants