Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't exit doc preparation even if changelog is empty for any provider #44207

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Don't exit doc preparation even if changelog is empty for any provider #44207

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b2678c1
Continue preparing provider docs even if changelog is empty for any p…
amoghrajesh Nov 20, 2024
91fad66
Merge branch 'main' into bug-rm-providers
amoghrajesh Nov 22, 2024
ed4c83c
fixing failing checks
amoghrajesh Nov 22, 2024
c8e4b2c
Merge branch 'main' into bug-rm-providers
amoghrajesh Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion dev/breeze/src/airflow_breeze/commands/release_management_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2195,7 +2195,7 @@ class ProviderPRInfo(NamedTuple):
f"[warning]Skipping provider {provider_id}. "
"The changelog file doesn't contain any PRs for the release.\n"
)
return
continue
provider_prs[provider_id] = [pr for pr in prs if pr not in excluded_prs]
all_prs.update(provider_prs[provider_id])
g = Github(github_token)
Expand Down Expand Up @@ -2245,6 +2245,8 @@ class ProviderPRInfo(NamedTuple):
progress.advance(task)
providers: dict[str, ProviderPRInfo] = {}
for provider_id in prepared_package_ids:
if provider_id not in provider_prs:
continue
pull_request_list = [pull_requests[pr] for pr in provider_prs[provider_id] if pr in pull_requests]
provider_yaml_dict = yaml.safe_load(
(
Expand Down