Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIP-84 Migrate public endpoint Clear Task Instances to FastAPI #44220

Merged
merged 5 commits into from
Nov 22, 2024
Merged

AIP-84 Migrate public endpoint Clear Task Instances to FastAPI #44220

merged 5 commits into from
Nov 22, 2024

Conversation

omkar-foss
Copy link
Collaborator

closes: #43751
related: #42370

This migrates the Clear Task Instances API from api_connexion to api_fastapi.

@omkar-foss omkar-foss self-assigned this Nov 20, 2024
@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Nov 20, 2024
@omkar-foss omkar-foss added legacy api Whether legacy API changes should be allowed in PR and removed area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Nov 20, 2024
@omkar-foss omkar-foss closed this Nov 20, 2024
@omkar-foss omkar-foss reopened this Nov 20, 2024
@omkar-foss omkar-foss marked this pull request as ready for review November 20, 2024 17:49
@omkar-foss
Copy link
Collaborator Author

Resolving conflicts from recent PR merges into main.

@omkar-foss
Copy link
Collaborator Author

Resolving conflicts from recent PR merges into main.

This is done, PR synced with main and all conflicts resolved ✅

@omkar-foss
Copy link
Collaborator Author

All checks passed, PR ready to review ✅

pierrejeambrun
pierrejeambrun reviewed Nov 21, 2024
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

A few suggestions (only #44220 (comment) requires change), we can merge after :)

airflow/api_fastapi/common/types.py Outdated Show resolved Hide resolved
airflow/api_fastapi/core_api/datamodels/task_instances.py Outdated Show resolved Hide resolved
airflow/api_fastapi/core_api/routes/public/task_instances.py Outdated Show resolved Hide resolved
airflow/api_fastapi/core_api/routes/public/task_instances.py Outdated Show resolved Hide resolved
airflow/api_fastapi/core_api/routes/public/task_instances.py Outdated Show resolved Hide resolved
tests/api_fastapi/conftest.py Show resolved Hide resolved
tests/api_fastapi/core_api/routes/public/test_task_instances.py Show resolved Hide resolved
tests/api_fastapi/core_api/routes/public/test_task_instances.py Outdated Show resolved Hide resolved
tests/api_fastapi/core_api/routes/public/test_task_instances.py Outdated Show resolved Hide resolved
@omkar-foss
Copy link
Collaborator Author

omkar-foss commented Nov 21, 2024 •
edited
Loading

Looking good!

A few suggestions (only #44220 (comment) requires change), we can merge after :)

Thanks @pierrejeambrun, I've made the changes as per your suggestions and resolved the corresponding conversations. Also rebased with main. Please have a look, thanks! 😁

pierrejeambrun
pierrejeambrun approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One extra nit, can be merged after that.

airflow/api_fastapi/core_api/datamodels/task_instances.py Show resolved Hide resolved
@omkar-foss
Copy link
Collaborator Author

@pierrejeambrun @bbovenzi Thank you for your reviews! I've updated the PR as per your suggestions and also rebased with main. Please check it out when possible, thanks 😁

@pierrejeambrun pierrejeambrun changed the title Migrate public endpoint Clear Task Instances to FastAPI AIP-84 Migrate public endpoint Clear Task Instances to FastAPI Nov 22, 2024
@pierrejeambrun pierrejeambrun added the AIP-84 Modern Rest API label Nov 22, 2024
@pierrejeambrun pierrejeambrun added this to the Airflow 3.0.0 milestone Nov 22, 2024
@pierrejeambrun
Copy link
Member

I just rebased the branch, to solve additional conflicts introduced by recent merge.

Should be good to merge.

@omkar-foss
Copy link
Collaborator Author

1 test failing after rebase, rebased again. It should pass now.

@pierrejeambrun pierrejeambrun merged commit 00fd540 into apache:main Nov 22, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbovenzi bbovenzi bbovenzi left review comments

@pierrejeambrun pierrejeambrun pierrejeambrun approved these changes

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@jscheffl jscheffl Awaiting requested review from jscheffl jscheffl is a code owner

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

Assignees

@omkar-foss omkar-foss

Labels
AIP-84 Modern Rest API legacy api Whether legacy API changes should be allowed in PR
Projects
None yet
Milestone
Airflow 3.0.0
Development

Successfully merging this pull request may close these issues.

AIP-84 Post Clear Task Instances
3 participants
@omkar-foss @pierrejeambrun @bbovenzi