AIP 72: Handling deferrable tasks in execution API as well as TASK SDK #44241
+129
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
reviewed
Nov 21, 2024
| next_method: str | ||
| # need to serialise to datetime.timedelta | ||
| timeout: str | None | ||
| # what about triggerer_id? |
There was a problem hiding this comment.
This gets set in the db once the API processes the request, so it shouldn't/can't be part of the request
There was a problem hiding this comment.
The trigger_id right? I need to remove this comment then
| timeout = ti_patch_payload.timeout | ||
| # Calculate timeout too if it was passed | ||
| if timeout is not None: | ||
| ti.trigger_timeout = timezone.utcnow() + timedelta(days=int(timeout)) |
There was a problem hiding this comment.
I need to handle it better based on what I can send from the client, this isn't right yet
| else: | ||
| ti.trigger_timeout = ti.start_date + execution_timeout | ||
|
|
||
| session.merge(ti) |
There was a problem hiding this comment.
Merge isn't needed - the object is already attached to the session
There was a problem hiding this comment.
Commit only will do, right?
| "state": "deferred", | ||
| "classpath": "my-class-path", | ||
| "kwargs": {}, | ||
| "created_date": "2024-10-31T12:00:00Z", |
There was a problem hiding this comment.
Hmm, why is this being sent in the payload? Should it be the time the server received the request instead?
Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
kaxil
reviewed
Nov 21, 2024
| @@ -105,7 +132,7 @@ class TIHeartbeatInfo(BaseModel): | |||
| class TaskInstance(BaseModel): | |||
| """Schema for TaskInstance model with minimal required fields needed for Runtime.""" | |||
|
|
|||
| id: uuid.UUID | |||
| id: uuid.UUID | int = 0 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.