Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate public endpoint Set Task Instances State to FastAPI #44246

Closed
wants to merge 3 commits into from
Closed

Migrate public endpoint Set Task Instances State to FastAPI #44246

wants to merge 3 commits into from

Conversation

omkar-foss
Copy link
Collaborator

closes: #43752
related: #42370

This migrates the Set Task Instances State API from api_connexion to api_fastapi.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Nov 21, 2024
@omkar-foss omkar-foss self-assigned this Nov 21, 2024
@omkar-foss omkar-foss added the legacy api Whether legacy API changes should be allowed in PR label Nov 21, 2024
@omkar-foss omkar-foss marked this pull request as ready for review November 21, 2024 13:11
pierrejeambrun
pierrejeambrun reviewed Nov 21, 2024
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we need that anymore. Isn't it already handled by the more generic PATCH task instance now ?

airflow/api_fastapi/core_api/routes/public/task_instances.py Show resolved Hide resolved
@bbovenzi
Copy link
Contributor

I think we should only merge one of this and #44223 and include setting a note and all the include_* filters to update other task instance states at the same time.

@omkar-foss omkar-foss closed this Nov 21, 2024
@omkar-foss
Copy link
Collaborator Author

Closed this PR as this functionality is handled by Patch Task Instance API in #44223 using update_mask = ["new_state"].

@omkar-foss omkar-foss mentioned this pull request Nov 21, 2024
Open
@omkar-foss omkar-foss deleted the aip-84/tis/post-tis-state branch November 21, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawwar rawwar rawwar left review comments

@pierrejeambrun pierrejeambrun pierrejeambrun left review comments

@bbovenzi bbovenzi bbovenzi left review comments

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@jscheffl jscheffl Awaiting requested review from jscheffl jscheffl is a code owner

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

Assignees

@omkar-foss omkar-foss

Labels
area:UI Related to UI/UX. For Frontend Developers. legacy api Whether legacy API changes should be allowed in PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AIP-84 Set Task Instances State
4 participants
@omkar-foss @bbovenzi @pierrejeambrun @rawwar