-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict pydantic 2.10.0 #44249
base: main
Are you sure you want to change the base?
Restrict pydantic 2.10.0 #44249
Conversation
We should have a patch release out this afternoon with a fix for the issues you're encountering :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we need to merge this or not given a 2.10.1 will be out soon
@sydney-runkle Do you plan on yanking the 2.10.0 release? (I don't mind either way, just need to know what we do) If 2.10.0 gets yanked then we don't need to keep this/can revert it, otherwise we probably should keep the exclusion rule |
f770009
to
8e60774
Compare
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
We're not going to yank v2.10.0, will just release a v2.10.1 patch soon! |
Perhaps you all could test against our |
It would be easier if you have an rc or beta/alpha released in PyPI - because I am not sure if we can trigger the whole test suite against Github-installed version. Can it be done @sydney-runkle ? |
You can try with |
It might be that we expect version in our CI for that, so I am not sure if it's going to work . I can try, but I have a feeling it will fail in one of the steps. |
yeah i think it might fail at constraints ? |
Trying it here @sydney-runkle #44260 |
Yeah... some tests are already failing here as I suspected. But those are auxiliary ones, maybe the main part of the tests that actually failed before will be ok:
|
We're going to release 2.10.1 any minute now. We got a report today of an issue happening on Python <3.10. The a.py from logging import Logger
class Base:
_log: 'Logger | None' b.py from a import Base
from pydantic import BaseModel
class Model(BaseModel, Base):
pass Evalutating the annotation for What's probably best is to make sure you're using the old syntax for every class that is going to be used in the context of a Pydantic model. |
Recent pydantic 2.10.0 release causing failures in CI.
It seems there is ticket already opened here. pydantic/pydantic#10910
Failing tests in CI https://github.com/apache/airflow/actions/runs/11954326679/job/33324739597#step:7:12365
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.