Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use airflow config in new UI #44252

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Use airflow config in new UI #44252

merged 2 commits into from
Nov 21, 2024

Conversation

bbovenzi
Copy link
Contributor

Use the new public/config api endpoint to make sure the UI uses config values. The public endpoint can we switched off. So later on we should migrate this to a dedicated ui/config endpoint.

Also, I didn't get around to show_trigger_form_if_no_params since we may also need API changes to make that work.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Nov 21, 2024
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, code looks good.

airflow/ui/src/queries/useConfig.tsx Outdated Show resolved Hide resolved
Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
@bbovenzi bbovenzi merged commit 970cb27 into apache:main Nov 21, 2024
37 checks passed
@bbovenzi bbovenzi deleted the ui-config branch November 21, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants