-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BigQueryInsertJobOperator: log transient error and check job state before marking task as success #44279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
Google (including GCP) related issues
labels
Nov 22, 2024
pankajastro
changed the title
BigQueryInsertJobOperator: log transient error and reload job propert…
BigQueryInsertJobOperator: log transient error and reload job property before marking task as failed or success
Nov 22, 2024
ephraimbuddy
approved these changes
Nov 22, 2024
providers/src/airflow/providers/google/cloud/operators/bigquery.py
Outdated
Show resolved
Hide resolved
There's another active PR: #40863 |
Closes this issue - #40839 |
Yeah, but it has some open discussions, and it's also a pretty old PR. so I thought maybe a new PR would easy. |
eladkal
previously requested changes
Nov 22, 2024
providers/src/airflow/providers/google/cloud/operators/bigquery.py
Outdated
Show resolved
Hide resolved
2 tasks
pankajastro
force-pushed
the
state_check_bq
branch
2 times, most recently
from
November 29, 2024 08:16
3b50de5
to
7a5e69a
Compare
…y before marking task as failed or success
pankajastro
force-pushed
the
state_check_bq
branch
from
November 29, 2024 08:17
7a5e69a
to
127c254
Compare
pankajastro
changed the title
BigQueryInsertJobOperator: log transient error and reload job property before marking task as failed or success
BigQueryInsertJobOperator: log transient error and check job state before marking task as success
Nov 29, 2024
shahar1
approved these changes
Nov 29, 2024
LefterisXefteris
pushed a commit
to LefterisXefteris/airflow
that referenced
this pull request
Jan 5, 2025
…fore marking task as success (apache#44279) * BigQueryInsertJobOperator: log transient error and check job state before marking task as success
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.