Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQueryInsertJobOperator: log transient error and check job state before marking task as success #44279

Merged
merged 6 commits into from
Dec 1, 2024

Conversation

pankajastro
Copy link
Member

@pankajastro pankajastro commented Nov 22, 2024


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Nov 22, 2024
@pankajastro pankajastro changed the title BigQueryInsertJobOperator: log transient error and reload job propert… BigQueryInsertJobOperator: log transient error and reload job property before marking task as failed or success Nov 22, 2024
@rawwar
Copy link
Collaborator

rawwar commented Nov 22, 2024

There's another active PR: #40863

@kandharvishnu
Copy link
Contributor

Closes this issue - #40839

@pankajastro
Copy link
Member Author

There's another active PR: #40863

Yeah, but it has some open discussions, and it's also a pretty old PR. so I thought maybe a new PR would easy.

@pankajastro pankajastro marked this pull request as ready for review November 22, 2024 12:42
@pankajastro pankajastro changed the title BigQueryInsertJobOperator: log transient error and reload job property before marking task as failed or success BigQueryInsertJobOperator: log transient error and check job state before marking task as success Nov 29, 2024
@pankajastro pankajastro requested a review from eladkal November 29, 2024 10:42
@pankajastro pankajastro dismissed eladkal’s stale review December 1, 2024 09:49

Discussed this offline

@pankajastro pankajastro merged commit d2eed7a into main Dec 1, 2024
65 checks passed
@pankajastro pankajastro deleted the state_check_bq branch December 1, 2024 09:50
LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
…fore marking task as success (apache#44279)

* BigQueryInsertJobOperator: log transient error and check job state before marking task as success
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants