Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move LatestOnlyOperator operator to standard provider. #44309

Merged

Conversation

hardeybisey
Copy link
Contributor

Moving latest_only operator to standard provider.

airflow/operators/latest_only.py >> providers/src/airflow/providers/standard/operators/latest_only.py

related: #43641


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@hardeybisey hardeybisey requested a review from potiuk as a code owner November 23, 2024 14:32
@hardeybisey hardeybisey marked this pull request as draft November 23, 2024 14:32
@hardeybisey hardeybisey force-pushed the move-latest-only-operator-to-standard-provider branch from 2b68548 to f54c35f Compare November 24, 2024 10:03
@hardeybisey hardeybisey marked this pull request as ready for review November 24, 2024 11:05
@eladkal eladkal requested a review from romsharon98 November 24, 2024 11:09
@hardeybisey hardeybisey force-pushed the move-latest-only-operator-to-standard-provider branch from f54c35f to 139ce7a Compare November 24, 2024 12:09
@hardeybisey hardeybisey marked this pull request as draft November 24, 2024 13:22
@hardeybisey hardeybisey marked this pull request as ready for review November 24, 2024 15:00
@hardeybisey hardeybisey force-pushed the move-latest-only-operator-to-standard-provider branch 2 times, most recently from 760da93 to 4d913a8 Compare November 29, 2024 09:10
Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipping the tests is "easy" but not necessarily "good" way of doing it. We should make the test also work with the older versions of airflow by adding conditional code.

@hardeybisey hardeybisey force-pushed the move-latest-only-operator-to-standard-provider branch from 4d913a8 to eb3998d Compare November 29, 2024 12:50
@hardeybisey
Copy link
Contributor Author

@potiuk Thanks for the review. I have made the test conditional based on the version it is running against.

@shahar1 shahar1 requested a review from potiuk November 30, 2024 07:30
@hardeybisey hardeybisey force-pushed the move-latest-only-operator-to-standard-provider branch from eb3998d to 3c2ee36 Compare November 30, 2024 10:36
@potiuk potiuk merged commit 57d109c into apache:main Nov 30, 2024
67 checks passed
LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
* Moved latest_only operator to standard provider along with all references

* Add latest_only operator to standard provider.yaml file.

* Move latest_only operator test file to Standard provider

* Add skip condition to latest_only_operator tests that are not backward compatible

* Revert skipping test to using a conditional code depending on airflow version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants