-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move LatestOnlyOperator
operator to standard provider.
#44309
Move LatestOnlyOperator
operator to standard provider.
#44309
Conversation
2b68548
to
f54c35f
Compare
f54c35f
to
139ce7a
Compare
760da93
to
4d913a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
providers/tests/standard/operators/test_latest_only_operator.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skipping the tests is "easy" but not necessarily "good" way of doing it. We should make the test also work with the older versions of airflow by adding conditional code.
4d913a8
to
eb3998d
Compare
@potiuk Thanks for the review. I have made the test conditional based on the version it is running against. |
eb3998d
to
3c2ee36
Compare
* Moved latest_only operator to standard provider along with all references * Add latest_only operator to standard provider.yaml file. * Move latest_only operator test file to Standard provider * Add skip condition to latest_only_operator tests that are not backward compatible * Revert skipping test to using a conditional code depending on airflow version
Moving latest_only operator to standard provider.
airflow/operators/latest_only.py
>>providers/src/airflow/providers/standard/operators/latest_only.py
related: #43641
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.