Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy-pasteable cherry-picker command if it fails to cherry-pick #44316

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Nov 23, 2024

When cherry-picker fails to backport a PR it adds a message to the PR explaining the failure and linking to the commit. This PR also adds a copy&pasteable cherry-picker command that the maintainer should run to retry it locally. It also explains what maintainer should do after solving the conflicts.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

When cherry-picker fails to backport a PR it adds a message to
the PR explaining the failure and linking to the commit. This PR
also adds a copy&pasteable cherry-picker command that the maintainer
should run to retry it locally. It also explains what
maintainer should do after solving the conflicts.
@kaxil kaxil added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Nov 24, 2024
@potiuk potiuk merged commit 49c6067 into apache:main Nov 24, 2024
92 of 93 checks passed
@potiuk potiuk deleted the better-cherry-picker-failure-message branch November 24, 2024 01:10
@gopidesupavan
Copy link
Member

Yeah, good one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants